switchdev: convert parent_id_get to switchdev attr get
Switch ID is just a gettable port attribute. Convert switchdev op switchdev_parent_id_get to a switchdev attr. Note: for sysfs and netlink interfaces, SWITCHDEV_ATTR_PORT_PARENT_ID is called with SWITCHDEV_F_NO_RECUSE to limit switch ID user-visiblity to only port netdevs. So when a port is stacked under bond/bridge, the user can only query switch id via the switch ports, but not via the upper devices Signed-off-by: Scott Feldman <sfeldma@gmail.com> Acked-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
3094333d90
commit
f8e20a9f87
@@ -4221,14 +4221,21 @@ static const struct net_device_ops rocker_port_netdev_ops = {
|
||||
* swdev interface
|
||||
********************/
|
||||
|
||||
static int rocker_port_switchdev_parent_id_get(struct net_device *dev,
|
||||
struct netdev_phys_item_id *psid)
|
||||
static int rocker_port_attr_get(struct net_device *dev,
|
||||
struct switchdev_attr *attr)
|
||||
{
|
||||
struct rocker_port *rocker_port = netdev_priv(dev);
|
||||
struct rocker *rocker = rocker_port->rocker;
|
||||
|
||||
psid->id_len = sizeof(rocker->hw.id);
|
||||
memcpy(&psid->id, &rocker->hw.id, psid->id_len);
|
||||
switch (attr->id) {
|
||||
case SWITCHDEV_ATTR_PORT_PARENT_ID:
|
||||
attr->ppid.id_len = sizeof(rocker->hw.id);
|
||||
memcpy(&attr->ppid.id, &rocker->hw.id, attr->ppid.id_len);
|
||||
break;
|
||||
default:
|
||||
return -EOPNOTSUPP;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -4266,7 +4273,7 @@ static int rocker_port_switchdev_fib_ipv4_del(struct net_device *dev,
|
||||
}
|
||||
|
||||
static const struct switchdev_ops rocker_port_switchdev_ops = {
|
||||
.switchdev_parent_id_get = rocker_port_switchdev_parent_id_get,
|
||||
.switchdev_port_attr_get = rocker_port_attr_get,
|
||||
.switchdev_port_stp_update = rocker_port_switchdev_port_stp_update,
|
||||
.switchdev_fib_ipv4_add = rocker_port_switchdev_fib_ipv4_add,
|
||||
.switchdev_fib_ipv4_del = rocker_port_switchdev_fib_ipv4_del,
|
||||
|
Reference in New Issue
Block a user