[media] bttv: don't setup the controls if there are no video devices
The no_video flag was checked in all other cases except one. Calling v4l2_ctrl_handler_setup() if no_video is 1 will crash. This wasn't noticed before since there are only two card types that set no_video to 1, so this type of hardware is quite rare. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Reported-by: Lorenz Röhrl <sheepshit@gmx.de> Tested-by: Lorenz Röhrl <sheepshit@gmx.de> Cc: stable@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
这个提交包含在:
@@ -4182,7 +4182,8 @@ static int bttv_probe(struct pci_dev *dev, const struct pci_device_id *pci_id)
|
||||
}
|
||||
btv->std = V4L2_STD_PAL;
|
||||
init_irqreg(btv);
|
||||
v4l2_ctrl_handler_setup(hdl);
|
||||
if (!bttv_tvcards[btv->c.type].no_video)
|
||||
v4l2_ctrl_handler_setup(hdl);
|
||||
if (hdl->error) {
|
||||
result = hdl->error;
|
||||
goto fail2;
|
||||
|
在新工单中引用
屏蔽一个用户