[SCSI] libosd: OSD2r05: OSD_CRYPTO_KEYID_SIZE will grow 20 => 32 bytes
In OSD2r04 draft, cryptographic key size changed to 32 bytes from OSD1's 20 bytes. This causes a couple of on-the-wire structures to change, including the CDB. In this patch the OSD1/OSD2 handling is separated out in regard to affected structures, but on-the-wire is still the same. All on the wire changes will be submitted in one patch for bisect-ability. Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:

committed by
James Bottomley

parent
71f32e31e5
commit
f8d3a644be
@@ -345,9 +345,9 @@ _osd_req_sec_params(struct osd_request *or)
|
||||
struct osd_cdb *ocdb = &or->cdb;
|
||||
|
||||
if (osd_req_is_ver1(or))
|
||||
return &ocdb->v1.sec_params;
|
||||
return (struct osd_security_parameters *)&ocdb->v1.sec_params;
|
||||
else
|
||||
return &ocdb->v2.sec_params;
|
||||
return (struct osd_security_parameters *)&ocdb->v2.sec_params;
|
||||
}
|
||||
|
||||
void osd_dev_init(struct osd_dev *osdd, struct scsi_device *scsi_device)
|
||||
@@ -1209,6 +1209,24 @@ static int _osd_req_finalize_attr_page(struct osd_request *or)
|
||||
return ret;
|
||||
}
|
||||
|
||||
static inline void osd_sec_parms_set_out_offset(bool is_v1,
|
||||
struct osd_security_parameters *sec_parms, osd_cdb_offset offset)
|
||||
{
|
||||
if (is_v1)
|
||||
sec_parms->v1.data_out_integrity_check_offset = offset;
|
||||
else
|
||||
sec_parms->v2.data_out_integrity_check_offset = offset;
|
||||
}
|
||||
|
||||
static inline void osd_sec_parms_set_in_offset(bool is_v1,
|
||||
struct osd_security_parameters *sec_parms, osd_cdb_offset offset)
|
||||
{
|
||||
if (is_v1)
|
||||
sec_parms->v1.data_in_integrity_check_offset = offset;
|
||||
else
|
||||
sec_parms->v2.data_in_integrity_check_offset = offset;
|
||||
}
|
||||
|
||||
static int _osd_req_finalize_data_integrity(struct osd_request *or,
|
||||
bool has_in, bool has_out, const u8 *cap_key)
|
||||
{
|
||||
@@ -1232,8 +1250,8 @@ static int _osd_req_finalize_data_integrity(struct osd_request *or,
|
||||
or->out_data_integ.get_attributes_bytes = cpu_to_be64(
|
||||
or->enc_get_attr.total_bytes);
|
||||
|
||||
sec_parms->data_out_integrity_check_offset =
|
||||
osd_req_encode_offset(or, or->out.total_bytes, &pad);
|
||||
osd_sec_parms_set_out_offset(osd_req_is_ver1(or), sec_parms,
|
||||
osd_req_encode_offset(or, or->out.total_bytes, &pad));
|
||||
|
||||
ret = _req_append_segment(or, pad, &seg, or->out.last_seg,
|
||||
&or->out);
|
||||
@@ -1253,8 +1271,8 @@ static int _osd_req_finalize_data_integrity(struct osd_request *or,
|
||||
};
|
||||
unsigned pad;
|
||||
|
||||
sec_parms->data_in_integrity_check_offset =
|
||||
osd_req_encode_offset(or, or->in.total_bytes, &pad);
|
||||
osd_sec_parms_set_in_offset(osd_req_is_ver1(or), sec_parms,
|
||||
osd_req_encode_offset(or, or->in.total_bytes, &pad));
|
||||
|
||||
ret = _req_append_segment(or, pad, &seg, or->in.last_seg,
|
||||
&or->in);
|
||||
|
Reference in New Issue
Block a user