xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/virtio: fix lock context imbalance

Browse Source 
When virtio_gpu_free_vbufs exits due to list empty, it does not
drop the free_vbufs lock that it took.
list empty is not expected to happen anyway, but it can't hurt to fix
this and drop the lock.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Michael S. Tsirkin
2016-12-05 22:36:56 +02:00
parent 8854a56f3e
commit f862e60f8d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/virtio/virtgpu_vq.c
View File

@@ -109,8 +109,10 @@ void virtio_gpu_free_vbufs(struct virtio_gpu_device *vgdev)
spin_lock(&vgdev->free_vbufs_lock); spin_lock(&vgdev->free_vbufs_lock);
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
if (WARN_ON(list_empty(&vgdev->free_vbufs))) if (WARN_ON(list_empty(&vgdev->free_vbufs))) {
spin_unlock(&vgdev->free_vbufs_lock);
return; return;
}
vbuf = list_first_entry(&vgdev->free_vbufs, vbuf = list_first_entry(&vgdev->free_vbufs,
struct virtio_gpu_vbuffer, list); struct virtio_gpu_vbuffer, list);
list_del(&vbuf->list); list_del(&vbuf->list);