xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

synclink: reduce pointless checks in ->ioctl()

Browse Source 
it's never getting called with TIOC[SG]SERIAL anymore (nor has
it ever supported those, while we are at it)

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2018-09-12 07:49:44 -04:00
parent 930236a308
commit f82fc0fedf
4 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/char/pcmcia/synclink_cs.c
View File

@@ -2237,8 +2237,7 @@ static int mgslpc_ioctl(struct tty_struct *tty,
if (mgslpc_paranoia_check(info, tty->name, "mgslpc_ioctl")) if (mgslpc_paranoia_check(info, tty->name, "mgslpc_ioctl"))
return -ENODEV; return -ENODEV;
if ((cmd != TIOCGSERIAL) && (cmd != TIOCSSERIAL) && if (cmd != TIOCMIWAIT) {
(cmd != TIOCMIWAIT)) {
if (tty_io_error(tty)) if (tty_io_error(tty))
return -EIO; return -EIO;
} }

3
drivers/tty/synclink.c
View File

@@ -2959,8 +2959,7 @@ static int mgsl_ioctl(struct tty_struct *tty,
if (mgsl_paranoia_check(info, tty->name, "mgsl_ioctl")) if (mgsl_paranoia_check(info, tty->name, "mgsl_ioctl"))
return -ENODEV; return -ENODEV;
if ((cmd != TIOCGSERIAL) && (cmd != TIOCSSERIAL) && if (cmd != TIOCMIWAIT) {
(cmd != TIOCMIWAIT)) {
if (tty_io_error(tty)) if (tty_io_error(tty))
return -EIO; return -EIO;
} }

3
drivers/tty/synclink_gt.c
View File

@@ -1029,8 +1029,7 @@ static int ioctl(struct tty_struct *tty,
return -ENODEV; return -ENODEV;
DBGINFO(("%s ioctl() cmd=%08X\n", info->device_name, cmd)); DBGINFO(("%s ioctl() cmd=%08X\n", info->device_name, cmd));
if ((cmd != TIOCGSERIAL) && (cmd != TIOCSSERIAL) && if (cmd != TIOCMIWAIT) {
(cmd != TIOCMIWAIT)) {
if (tty_io_error(tty)) if (tty_io_error(tty))
return -EIO; return -EIO;
} }

3
drivers/tty/synclinkmp.c
View File

@@ -1259,8 +1259,7 @@ static int ioctl(struct tty_struct *tty,
if (sanity_check(info, tty->name, "ioctl")) if (sanity_check(info, tty->name, "ioctl"))
return -ENODEV; return -ENODEV;
if ((cmd != TIOCGSERIAL) && (cmd != TIOCSSERIAL) && if (cmd != TIOCMIWAIT) {
(cmd != TIOCMIWAIT)) {
if (tty_io_error(tty)) if (tty_io_error(tty))
return -EIO; return -EIO;
} }