signal/ptrace: Add force_sig_ptrace_errno_trap and use it where needed
There are so many places that build struct siginfo by hand that at least one of them is bound to get it wrong. A handful of cases in the kernel arguably did just that when using the errno field of siginfo to pass no errno values to userspace. The usage is limited to a single si_code so at least does not mess up anything else. Encapsulate this questionable pattern in a helper function so that the userspace ABI is preserved. Update all of the places that use this pattern to use the new helper function. Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
This commit is contained in:
@@ -278,7 +278,6 @@ static void ptrace_hbptriggered(struct perf_event *bp,
|
||||
struct pt_regs *regs)
|
||||
{
|
||||
int i;
|
||||
siginfo_t info;
|
||||
struct arch_hw_breakpoint *bkpt = counter_arch_bp(bp);
|
||||
|
||||
if (bp->attr.bp_type & HW_BREAKPOINT_X) {
|
||||
@@ -293,12 +292,7 @@ static void ptrace_hbptriggered(struct perf_event *bp,
|
||||
i = (i << 1) | 1;
|
||||
}
|
||||
|
||||
info.si_signo = SIGTRAP;
|
||||
info.si_errno = i;
|
||||
info.si_code = TRAP_HWBKPT;
|
||||
info.si_addr = (void __user *)bkpt->address;
|
||||
|
||||
force_sig_info(SIGTRAP, &info, current);
|
||||
force_sig_ptrace_errno_trap(i, (void __user *)bkpt->address);
|
||||
}
|
||||
|
||||
static struct perf_event *ptrace_hbp_create(struct task_struct *tsk, int type)
|
||||
|
Reference in New Issue
Block a user