Merge tag 'driver-core-5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
Pull driver core and debugfs updates from Greg KH: "Here is the "big" driver core and debugfs changes for 5.3-rc1 It's a lot of different patches, all across the tree due to some api changes and lots of debugfs cleanups. Other than the debugfs cleanups, in this set of changes we have: - bus iteration function cleanups - scripts/get_abi.pl tool to display and parse Documentation/ABI entries in a simple way - cleanups to Documenatation/ABI/ entries to make them parse easier due to typos and other minor things - default_attrs use for some ktype users - driver model documentation file conversions to .rst - compressed firmware file loading - deferred probe fixes All of these have been in linux-next for a while, with a bunch of merge issues that Stephen has been patient with me for" * tag 'driver-core-5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: (102 commits) debugfs: make error message a bit more verbose orangefs: fix build warning from debugfs cleanup patch ubifs: fix build warning after debugfs cleanup patch driver: core: Allow subsystems to continue deferring probe drivers: base: cacheinfo: Ensure cpu hotplug work is done before Intel RDT arch_topology: Remove error messages on out-of-memory conditions lib: notifier-error-inject: no need to check return value of debugfs_create functions swiotlb: no need to check return value of debugfs_create functions ceph: no need to check return value of debugfs_create functions sunrpc: no need to check return value of debugfs_create functions ubifs: no need to check return value of debugfs_create functions orangefs: no need to check return value of debugfs_create functions nfsd: no need to check return value of debugfs_create functions lib: 842: no need to check return value of debugfs_create functions debugfs: provide pr_fmt() macro debugfs: log errors when something goes wrong drivers: s390/cio: Fix compilation warning about const qualifiers drivers: Add generic helper to match by of_node driver_find_device: Unify the match function with class_find_device() bus_find_device: Unify the match callback with class_find_device ...
This commit is contained in:
@@ -22,8 +22,6 @@ static int __init sw842_debugfs_create(void)
|
||||
return -ENODEV;
|
||||
|
||||
sw842_debugfs_root = debugfs_create_dir(MODULE_NAME, NULL);
|
||||
if (IS_ERR(sw842_debugfs_root))
|
||||
return PTR_ERR(sw842_debugfs_root);
|
||||
|
||||
for (i = 0; i < ARRAY_SIZE(template_count); i++) {
|
||||
char name[32];
|
||||
@@ -46,8 +44,7 @@ static int __init sw842_debugfs_create(void)
|
||||
|
||||
static void __exit sw842_debugfs_remove(void)
|
||||
{
|
||||
if (sw842_debugfs_root && !IS_ERR(sw842_debugfs_root))
|
||||
debugfs_remove_recursive(sw842_debugfs_root);
|
||||
debugfs_remove_recursive(sw842_debugfs_root);
|
||||
}
|
||||
|
||||
#endif
|
||||
|
@@ -993,20 +993,14 @@ static __initdata int ddebug_init_success;
|
||||
|
||||
static int __init dynamic_debug_init_debugfs(void)
|
||||
{
|
||||
struct dentry *dir, *file;
|
||||
struct dentry *dir;
|
||||
|
||||
if (!ddebug_init_success)
|
||||
return -ENODEV;
|
||||
|
||||
dir = debugfs_create_dir("dynamic_debug", NULL);
|
||||
if (!dir)
|
||||
return -ENOMEM;
|
||||
file = debugfs_create_file("control", 0644, dir, NULL,
|
||||
&ddebug_proc_fops);
|
||||
if (!file) {
|
||||
debugfs_remove(dir);
|
||||
return -ENOMEM;
|
||||
}
|
||||
debugfs_create_file("control", 0644, dir, NULL, &ddebug_proc_fops);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@@ -166,10 +166,10 @@ static int debugfs_ul_get(void *data, u64 *val)
|
||||
|
||||
DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n");
|
||||
|
||||
static struct dentry *debugfs_create_ul(const char *name, umode_t mode,
|
||||
struct dentry *parent, unsigned long *value)
|
||||
static void debugfs_create_ul(const char *name, umode_t mode,
|
||||
struct dentry *parent, unsigned long *value)
|
||||
{
|
||||
return debugfs_create_file(name, mode, parent, value, &fops_ul);
|
||||
debugfs_create_file(name, mode, parent, value, &fops_ul);
|
||||
}
|
||||
|
||||
#ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
|
||||
@@ -185,12 +185,11 @@ static int debugfs_stacktrace_depth_set(void *data, u64 val)
|
||||
DEFINE_SIMPLE_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get,
|
||||
debugfs_stacktrace_depth_set, "%llu\n");
|
||||
|
||||
static struct dentry *debugfs_create_stacktrace_depth(
|
||||
const char *name, umode_t mode,
|
||||
struct dentry *parent, unsigned long *value)
|
||||
static void debugfs_create_stacktrace_depth(const char *name, umode_t mode,
|
||||
struct dentry *parent,
|
||||
unsigned long *value)
|
||||
{
|
||||
return debugfs_create_file(name, mode, parent, value,
|
||||
&fops_stacktrace_depth);
|
||||
debugfs_create_file(name, mode, parent, value, &fops_stacktrace_depth);
|
||||
}
|
||||
|
||||
#endif /* CONFIG_FAULT_INJECTION_STACKTRACE_FILTER */
|
||||
@@ -202,51 +201,31 @@ struct dentry *fault_create_debugfs_attr(const char *name,
|
||||
struct dentry *dir;
|
||||
|
||||
dir = debugfs_create_dir(name, parent);
|
||||
if (!dir)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
if (IS_ERR(dir))
|
||||
return dir;
|
||||
|
||||
if (!debugfs_create_ul("probability", mode, dir, &attr->probability))
|
||||
goto fail;
|
||||
if (!debugfs_create_ul("interval", mode, dir, &attr->interval))
|
||||
goto fail;
|
||||
if (!debugfs_create_atomic_t("times", mode, dir, &attr->times))
|
||||
goto fail;
|
||||
if (!debugfs_create_atomic_t("space", mode, dir, &attr->space))
|
||||
goto fail;
|
||||
if (!debugfs_create_ul("verbose", mode, dir, &attr->verbose))
|
||||
goto fail;
|
||||
if (!debugfs_create_u32("verbose_ratelimit_interval_ms", mode, dir,
|
||||
&attr->ratelimit_state.interval))
|
||||
goto fail;
|
||||
if (!debugfs_create_u32("verbose_ratelimit_burst", mode, dir,
|
||||
&attr->ratelimit_state.burst))
|
||||
goto fail;
|
||||
if (!debugfs_create_bool("task-filter", mode, dir, &attr->task_filter))
|
||||
goto fail;
|
||||
debugfs_create_ul("probability", mode, dir, &attr->probability);
|
||||
debugfs_create_ul("interval", mode, dir, &attr->interval);
|
||||
debugfs_create_atomic_t("times", mode, dir, &attr->times);
|
||||
debugfs_create_atomic_t("space", mode, dir, &attr->space);
|
||||
debugfs_create_ul("verbose", mode, dir, &attr->verbose);
|
||||
debugfs_create_u32("verbose_ratelimit_interval_ms", mode, dir,
|
||||
&attr->ratelimit_state.interval);
|
||||
debugfs_create_u32("verbose_ratelimit_burst", mode, dir,
|
||||
&attr->ratelimit_state.burst);
|
||||
debugfs_create_bool("task-filter", mode, dir, &attr->task_filter);
|
||||
|
||||
#ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
|
||||
|
||||
if (!debugfs_create_stacktrace_depth("stacktrace-depth", mode, dir,
|
||||
&attr->stacktrace_depth))
|
||||
goto fail;
|
||||
if (!debugfs_create_ul("require-start", mode, dir,
|
||||
&attr->require_start))
|
||||
goto fail;
|
||||
if (!debugfs_create_ul("require-end", mode, dir, &attr->require_end))
|
||||
goto fail;
|
||||
if (!debugfs_create_ul("reject-start", mode, dir, &attr->reject_start))
|
||||
goto fail;
|
||||
if (!debugfs_create_ul("reject-end", mode, dir, &attr->reject_end))
|
||||
goto fail;
|
||||
|
||||
debugfs_create_stacktrace_depth("stacktrace-depth", mode, dir,
|
||||
&attr->stacktrace_depth);
|
||||
debugfs_create_ul("require-start", mode, dir, &attr->require_start);
|
||||
debugfs_create_ul("require-end", mode, dir, &attr->require_end);
|
||||
debugfs_create_ul("reject-start", mode, dir, &attr->reject_start);
|
||||
debugfs_create_ul("reject-end", mode, dir, &attr->reject_end);
|
||||
#endif /* CONFIG_FAULT_INJECTION_STACKTRACE_FILTER */
|
||||
|
||||
attr->dname = dget(dir);
|
||||
return dir;
|
||||
fail:
|
||||
debugfs_remove_recursive(dir);
|
||||
|
||||
return ERR_PTR(-ENOMEM);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(fault_create_debugfs_attr);
|
||||
|
||||
|
@@ -498,8 +498,10 @@ int kobject_rename(struct kobject *kobj, const char *new_name)
|
||||
kobj = kobject_get(kobj);
|
||||
if (!kobj)
|
||||
return -EINVAL;
|
||||
if (!kobj->parent)
|
||||
if (!kobj->parent) {
|
||||
kobject_put(kobj);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
devpath = kobject_get_path(kobj, GFP_KERNEL);
|
||||
if (!devpath) {
|
||||
|
@@ -59,33 +59,22 @@ struct dentry *notifier_err_inject_init(const char *name, struct dentry *parent,
|
||||
err_inject->nb.priority = priority;
|
||||
|
||||
dir = debugfs_create_dir(name, parent);
|
||||
if (!dir)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
|
||||
actions_dir = debugfs_create_dir("actions", dir);
|
||||
if (!actions_dir)
|
||||
goto fail;
|
||||
|
||||
for (action = err_inject->actions; action->name; action++) {
|
||||
struct dentry *action_dir;
|
||||
|
||||
action_dir = debugfs_create_dir(action->name, actions_dir);
|
||||
if (!action_dir)
|
||||
goto fail;
|
||||
|
||||
/*
|
||||
* Create debugfs r/w file containing action->error. If
|
||||
* notifier call chain is called with action->val, it will
|
||||
* fail with the error code
|
||||
*/
|
||||
if (!debugfs_create_errno("error", mode, action_dir,
|
||||
&action->error))
|
||||
goto fail;
|
||||
debugfs_create_errno("error", mode, action_dir, &action->error);
|
||||
}
|
||||
return dir;
|
||||
fail:
|
||||
debugfs_remove_recursive(dir);
|
||||
return ERR_PTR(-ENOMEM);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(notifier_err_inject_init);
|
||||
|
||||
|
Reference in New Issue
Block a user