SUNRPC: Remove redundant calls to rpciod_up()/rpciod_down()
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
@@ -429,29 +429,23 @@ nfsd4_probe_callback(struct nfs4_client *clp)
|
||||
goto out_err;
|
||||
}
|
||||
|
||||
/* Kick rpciod, put the call on the wire. */
|
||||
if (rpciod_up() != 0)
|
||||
goto out_clnt;
|
||||
|
||||
/* the task holds a reference to the nfs4_client struct */
|
||||
atomic_inc(&clp->cl_count);
|
||||
|
||||
msg.rpc_cred = nfsd4_lookupcred(clp,0);
|
||||
if (IS_ERR(msg.rpc_cred))
|
||||
goto out_rpciod;
|
||||
goto out_release_clp;
|
||||
status = rpc_call_async(cb->cb_client, &msg, RPC_TASK_ASYNC, &nfs4_cb_null_ops, NULL);
|
||||
put_rpccred(msg.rpc_cred);
|
||||
|
||||
if (status != 0) {
|
||||
dprintk("NFSD: asynchronous NFSPROC4_CB_NULL failed!\n");
|
||||
goto out_rpciod;
|
||||
goto out_release_clp;
|
||||
}
|
||||
return;
|
||||
|
||||
out_rpciod:
|
||||
out_release_clp:
|
||||
atomic_dec(&clp->cl_count);
|
||||
rpciod_down();
|
||||
out_clnt:
|
||||
rpc_shutdown_client(cb->cb_client);
|
||||
out_err:
|
||||
cb->cb_client = NULL;
|
||||
|
@@ -378,7 +378,6 @@ shutdown_callback_client(struct nfs4_client *clp)
|
||||
if (clnt) {
|
||||
clp->cl_callback.cb_client = NULL;
|
||||
rpc_shutdown_client(clnt);
|
||||
rpciod_down();
|
||||
}
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user