SUNRPC: get rid of cl_chatty
Clean up: Every ULP that uses the in-kernel RPC client, except the NLM client, sets cl_chatty. There's no reason why NLM shouldn't set it, so just get rid of cl_chatty and always be verbose. Test-plan: Compile with CONFIG_NFS enabled. Signed-off-by: Chuck Lever <cel@netapp.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
此提交包含在:
@@ -957,8 +957,7 @@ call_status(struct rpc_task *task)
|
||||
rpc_exit(task, status);
|
||||
break;
|
||||
default:
|
||||
if (clnt->cl_chatty)
|
||||
printk("%s: RPC call returned error %d\n",
|
||||
printk("%s: RPC call returned error %d\n",
|
||||
clnt->cl_protname, -status);
|
||||
rpc_exit(task, status);
|
||||
break;
|
||||
@@ -993,14 +992,13 @@ call_timeout(struct rpc_task *task)
|
||||
|
||||
dprintk("RPC: %4d call_timeout (major)\n", task->tk_pid);
|
||||
if (RPC_IS_SOFT(task)) {
|
||||
if (clnt->cl_chatty)
|
||||
printk(KERN_NOTICE "%s: server %s not responding, timed out\n",
|
||||
printk(KERN_NOTICE "%s: server %s not responding, timed out\n",
|
||||
clnt->cl_protname, clnt->cl_server);
|
||||
rpc_exit(task, -EIO);
|
||||
return;
|
||||
}
|
||||
|
||||
if (clnt->cl_chatty && !(task->tk_flags & RPC_CALL_MAJORSEEN)) {
|
||||
if (!(task->tk_flags & RPC_CALL_MAJORSEEN)) {
|
||||
task->tk_flags |= RPC_CALL_MAJORSEEN;
|
||||
printk(KERN_NOTICE "%s: server %s not responding, still trying\n",
|
||||
clnt->cl_protname, clnt->cl_server);
|
||||
@@ -1027,7 +1025,7 @@ call_decode(struct rpc_task *task)
|
||||
dprintk("RPC: %4d call_decode (status %d)\n",
|
||||
task->tk_pid, task->tk_status);
|
||||
|
||||
if (clnt->cl_chatty && (task->tk_flags & RPC_CALL_MAJORSEEN)) {
|
||||
if (task->tk_flags & RPC_CALL_MAJORSEEN) {
|
||||
printk(KERN_NOTICE "%s: server %s OK\n",
|
||||
clnt->cl_protname, clnt->cl_server);
|
||||
task->tk_flags &= ~RPC_CALL_MAJORSEEN;
|
||||
|
新增問題並參考
封鎖使用者