xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: 8250_omap: fix a timeout loop condition

Browse Source 
[ Upstream commit d7e325aaa8c3593b5a572b583ecad79e95f32e7f ]

This loop ends on -1 so the error message will never be printed.

Fixes: 4bcf59a5de ("serial: 8250: 8250_omap: Account for data in flight during DMA teardown")
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YIpd+kOpXKMpEXPf@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter
2021-04-29 10:19:22 +03:00
committed by Greg Kroah-Hartman
parent 5dcff72fe4
commit f5186bd17f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/serial/8250/8250_omap.c
View File

@@ -784,7 +784,7 @@ static void __dma_rx_do_complete(struct uart_8250_port *p)
poll_count--) poll_count--)
cpu_relax(); cpu_relax();
if (!poll_count) if (poll_count == -1)
dev_err(p->port.dev, "teardown incomplete\n"); dev_err(p->port.dev, "teardown incomplete\n");
} }
} }