[NETNS]: Simplify the network namespace list locking rules.

Denis V. Lunev <den@sw.ru> noticed that the locking rules
for the network namespace list are over complicated and broken.

In particular the current register_netdev_notifier currently
does not take any lock making the for_each_net iteration racy
with network namespace creation and destruction. Oops.

The fact that we need to use for_each_net in rtnl_unlock() when
the rtnetlink support becomes per network namespace makes designing
the proper locking tricky.  In addition we need to be able to call
rtnl_lock() and rtnl_unlock() when we have the net_mutex held.

After thinking about it and looking at the alternatives carefully
it looks like the simplest and most maintainable solution is
to remove net_list_mutex altogether, and to use the rtnl_mutex instead.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric W. Biederman
2007-09-26 22:40:08 -07:00
committed by David S. Miller
parent 32db927686
commit f4618d39a3
2 changed files with 6 additions and 20 deletions

View File

@@ -96,9 +96,6 @@ static inline void release_net(struct net *net)
#endif
}
extern void net_lock(void);
extern void net_unlock(void);
#define for_each_net(VAR) \
list_for_each_entry(VAR, &net_namespace_list, list)