mac80211: uapsd_queues is in QoS IE order
The uapsd_queue field is in QoS IE order and not in IEEE80211_AC_*'s order. This means that mac80211 would get confused between BK and BE which is certainly not such a big deal but needs to be fixed. Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:

committed by
Johannes Berg

parent
f3fe4e93dd
commit
f438ceb81d
@@ -709,7 +709,7 @@ static void __sta_info_recalc_tim(struct sta_info *sta, bool ignore_pending)
|
||||
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
|
||||
unsigned long tids;
|
||||
|
||||
if (ignore_for_tim & BIT(ac))
|
||||
if (ignore_for_tim & ieee80211_ac_to_qos_mask[ac])
|
||||
continue;
|
||||
|
||||
indicate_tim |= !skb_queue_empty(&sta->tx_filtered[ac]) ||
|
||||
@@ -1389,7 +1389,7 @@ ieee80211_sta_ps_more_data(struct sta_info *sta, u8 ignored_acs,
|
||||
return true;
|
||||
|
||||
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
|
||||
if (ignored_acs & BIT(ac))
|
||||
if (ignored_acs & ieee80211_ac_to_qos_mask[ac])
|
||||
continue;
|
||||
|
||||
if (!skb_queue_empty(&sta->tx_filtered[ac]) ||
|
||||
@@ -1414,7 +1414,7 @@ ieee80211_sta_ps_get_frames(struct sta_info *sta, int n_frames, u8 ignored_acs,
|
||||
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
|
||||
unsigned long tids;
|
||||
|
||||
if (ignored_acs & BIT(ac))
|
||||
if (ignored_acs & ieee80211_ac_to_qos_mask[ac])
|
||||
continue;
|
||||
|
||||
tids = ieee80211_tids_for_ac(ac);
|
||||
@@ -1482,7 +1482,7 @@ ieee80211_sta_ps_deliver_response(struct sta_info *sta,
|
||||
BIT(find_highest_prio_tid(driver_release_tids));
|
||||
|
||||
if (skb_queue_empty(&frames) && !driver_release_tids) {
|
||||
int tid;
|
||||
int tid, ac;
|
||||
|
||||
/*
|
||||
* For PS-Poll, this can only happen due to a race condition
|
||||
@@ -1500,7 +1500,10 @@ ieee80211_sta_ps_deliver_response(struct sta_info *sta,
|
||||
*/
|
||||
|
||||
/* This will evaluate to 1, 3, 5 or 7. */
|
||||
tid = 7 - ((ffs(~ignored_acs) - 1) << 1);
|
||||
for (ac = IEEE80211_AC_VO; ac < IEEE80211_NUM_ACS; ac++)
|
||||
if (ignored_acs & BIT(ac))
|
||||
continue;
|
||||
tid = 7 - 2 * ac;
|
||||
|
||||
ieee80211_send_null_response(sta, tid, reason, true, false);
|
||||
} else if (!driver_release_tids) {
|
||||
|
Reference in New Issue
Block a user