sched: Remove __ARCH_WANT_INTERRUPTS_ON_CTXSW
Now that the last architecture to use this has stopped doing so (ARM, thanks Catalin!) we can remove this complexity from the scheduler core. Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Link: http://lkml.kernel.org/n/tip-g9p2a1w81xxbrze25v9zpzbf@git.kernel.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:

committed by
Ingo Molnar

parent
5ed4f1d96d
commit
f3e9478674
@@ -1361,25 +1361,6 @@ static void ttwu_queue_remote(struct task_struct *p, int cpu)
|
||||
smp_send_reschedule(cpu);
|
||||
}
|
||||
|
||||
#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
|
||||
static int ttwu_activate_remote(struct task_struct *p, int wake_flags)
|
||||
{
|
||||
struct rq *rq;
|
||||
int ret = 0;
|
||||
|
||||
rq = __task_rq_lock(p);
|
||||
if (p->on_cpu) {
|
||||
ttwu_activate(rq, p, ENQUEUE_WAKEUP);
|
||||
ttwu_do_wakeup(rq, p, wake_flags);
|
||||
ret = 1;
|
||||
}
|
||||
__task_rq_unlock(rq);
|
||||
|
||||
return ret;
|
||||
|
||||
}
|
||||
#endif /* __ARCH_WANT_INTERRUPTS_ON_CTXSW */
|
||||
|
||||
bool cpus_share_cache(int this_cpu, int that_cpu)
|
||||
{
|
||||
return per_cpu(sd_llc_id, this_cpu) == per_cpu(sd_llc_id, that_cpu);
|
||||
@@ -1440,21 +1421,8 @@ try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
|
||||
* If the owning (remote) cpu is still in the middle of schedule() with
|
||||
* this task as prev, wait until its done referencing the task.
|
||||
*/
|
||||
while (p->on_cpu) {
|
||||
#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
|
||||
/*
|
||||
* In case the architecture enables interrupts in
|
||||
* context_switch(), we cannot busy wait, since that
|
||||
* would lead to deadlocks when an interrupt hits and
|
||||
* tries to wake up @prev. So bail and do a complete
|
||||
* remote wakeup.
|
||||
*/
|
||||
if (ttwu_activate_remote(p, wake_flags))
|
||||
goto stat;
|
||||
#else
|
||||
while (p->on_cpu)
|
||||
cpu_relax();
|
||||
#endif
|
||||
}
|
||||
/*
|
||||
* Pairs with the smp_wmb() in finish_lock_switch().
|
||||
*/
|
||||
@@ -1798,13 +1766,7 @@ static void finish_task_switch(struct rq *rq, struct task_struct *prev)
|
||||
prev_state = prev->state;
|
||||
account_switch_vtime(prev);
|
||||
finish_arch_switch(prev);
|
||||
#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
|
||||
local_irq_disable();
|
||||
#endif /* __ARCH_WANT_INTERRUPTS_ON_CTXSW */
|
||||
perf_event_task_sched_in(prev, current);
|
||||
#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
|
||||
local_irq_enable();
|
||||
#endif /* __ARCH_WANT_INTERRUPTS_ON_CTXSW */
|
||||
finish_lock_switch(rq, prev);
|
||||
finish_arch_post_lock_switch();
|
||||
|
||||
|
Reference in New Issue
Block a user