xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] chardev: GPIO for SCx200 & PC-8736x: use dev_dbg in common module

Browse Source 
Use of dev_dbg() and friends is considered good practice.  dev_dbg() needs a
struct device *devp, but nsc_gpio is only a helper module, so it doesnt
have/need its own.  To provide devp to the user-modules (scx200 & pc8736x
_gpio), we add it to the vtable, and set it during init.

Also squeeze nsc_gpio_dump()'s format a little.

[  199.259879]  pc8736x_gpio.0: io09: 0x0044 TS OD PUE  EDGE LO DEBOUNCE

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Jim Cromie
2006-06-27 02:54:23 -07:00
committed by Linus Torvalds
parent 58b087cda1
commit f31000e573
4 changed files with 34 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/char/pc8736x_gpio.c
View File

@@ -207,8 +207,6 @@ static void pc8736x_gpio_change(unsigned index)
pc8736x_gpio_set(index, !pc8736x_gpio_get(index));
}
extern void nsc_gpio_dump(unsigned iminor);
static struct nsc_gpio_ops pc8736x_access = {
.owner = THIS_MODULE,
.gpio_config = pc8736x_gpio_configure,
@@ -260,6 +258,7 @@ static int __init pc8736x_gpio_init(void)
dev_err(&pdev->dev, "no device found\n");
goto undo_platform_dev_add;
}
pc8736x_access.dev = &pdev->dev;
/* Verify that chip and it's GPIO unit are both enabled.
My BIOS does this, so I take minimum action here