mm: replace access_process_vm() write parameter with gup_flags
This removes the 'write' argument from access_process_vm() and replaces it with 'gup_flags' as use of this function previously silently implied FOLL_FORCE, whereas after this patch callers explicitly pass this flag. We make this explicit as use of FOLL_FORCE can result in surprising behaviour (and hence bugs) within the mm subsystem. Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com> Acked-by: Jesper Nilsson <jesper.nilsson@axis.com> Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
6347e8d5bc
commit
f307ab6dce
@@ -1861,7 +1861,8 @@ int access_remote_vm(struct mm_struct *mm, unsigned long addr,
|
||||
* Access another process' address space.
|
||||
* - source/target buffer must be kernel space
|
||||
*/
|
||||
int access_process_vm(struct task_struct *tsk, unsigned long addr, void *buf, int len, int write)
|
||||
int access_process_vm(struct task_struct *tsk, unsigned long addr, void *buf, int len,
|
||||
unsigned int gup_flags)
|
||||
{
|
||||
struct mm_struct *mm;
|
||||
|
||||
@@ -1872,8 +1873,7 @@ int access_process_vm(struct task_struct *tsk, unsigned long addr, void *buf, in
|
||||
if (!mm)
|
||||
return 0;
|
||||
|
||||
len = __access_remote_vm(tsk, mm, addr, buf, len,
|
||||
write ? FOLL_WRITE : 0);
|
||||
len = __access_remote_vm(tsk, mm, addr, buf, len, gup_flags);
|
||||
|
||||
mmput(mm);
|
||||
return len;
|
||||
|
Reference in New Issue
Block a user