MD: set journal disk ->raid_disk
Set journal disk ->raid_disk to >=0, I choose raid_disks + 1 instead of 0, because we already have a disk with ->raid_disk 0 and this causes sysfs entry creation conflict. A lot of places assumes disk with ->raid_disk >=0 is normal raid disk, so we add check for journal disk. Signed-off-by: Shaohua Li <shli@fb.com> Signed-off-by: NeilBrown <neilb@suse.com>
This commit is contained in:
@@ -6560,7 +6560,7 @@ static struct r5conf *setup_conf(struct mddev *mddev)
|
||||
rdev_for_each(rdev, mddev) {
|
||||
raid_disk = rdev->raid_disk;
|
||||
if (raid_disk >= max_disks
|
||||
|| raid_disk < 0)
|
||||
|| raid_disk < 0 || test_bit(Journal, &rdev->flags))
|
||||
continue;
|
||||
disk = conf->disks + raid_disk;
|
||||
|
||||
@@ -6694,8 +6694,10 @@ static int run(struct mddev *mddev)
|
||||
rdev_for_each(rdev, mddev) {
|
||||
long long diff;
|
||||
|
||||
if (test_bit(Journal, &rdev->flags))
|
||||
if (test_bit(Journal, &rdev->flags)) {
|
||||
journal_dev = rdev;
|
||||
continue;
|
||||
}
|
||||
if (rdev->raid_disk < 0)
|
||||
continue;
|
||||
diff = (rdev->new_data_offset - rdev->data_offset);
|
||||
|
Reference in New Issue
Block a user