xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

macintosh: Use of_node_name_{eq, prefix} for node name comparisons

Browse Source 
Convert string compares of DT node names to use of_node_name_{eq,prefix}
helpers instead. This removes direct access to the node name pointer.

This changes a single case insensitive node name comparison to case
sensitive for "ata4". This is the only instance of a case insensitive
comparison for all the open coded node name comparisons on powerpc.
Searching the commit history, there doesn't appear to be any reason for
it to be case insensitive.

A couple of open coded iterating thru the child node names are converted
to use for_each_child_of_node() instead.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Rob Herring
2018-12-05 13:50:28 -06:00
committed by Michael Ellerman
parent c1fa31b0fc
commit f1e0addca8
7 changed files with 30 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/macintosh/windfarm_lm87_sensor.c
View File

@@ -110,8 +110,8 @@ static int wf_lm87_probe(struct i2c_client *client,
* the Xserve G5 has several lm87's. However, for now we only
* care about the internal temperature sensor
*/
while ((np = of_get_next_child(client->dev.of_node, np)) != NULL) {
if (strcmp(np->name, "int-temp"))
for_each_child_of_node(client->dev.of_node, np) {
if (!of_node_name_eq(np, "int-temp"))
continue;
loc = of_get_property(np, "location", NULL);
if (!loc)