xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ixgbevf: Fix resource leak in ixgbevf_init_module()

Browse Source 
[ Upstream commit 8cfa238a48f34038464b99d0b4825238c2687181 ]

ixgbevf_init_module() won't destroy the workqueue created by
create_singlethread_workqueue() when pci_register_driver() failed. Add
destroy_workqueue() in fail path to prevent the resource leak.

Similar to the handling of u132_hcd_init in commit f276e00279
("usb: u132-hcd: fix resource leak")

Fixes: 40a13e2493 ("ixgbevf: Use a private workqueue to avoid certain possible hangs")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Shang XiaoJing
2022-11-14 10:57:58 +08:00
committed by Greg Kroah-Hartman
parent 8f7047f418
commit f166c62cad
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
View File

@@ -4878,6 +4878,8 @@ static struct pci_driver ixgbevf_driver = {
**/ **/
static int __init ixgbevf_init_module(void) static int __init ixgbevf_init_module(void)
{ {
int err;
pr_info("%s\n", ixgbevf_driver_string); pr_info("%s\n", ixgbevf_driver_string);
pr_info("%s\n", ixgbevf_copyright); pr_info("%s\n", ixgbevf_copyright);
ixgbevf_wq = create_singlethread_workqueue(ixgbevf_driver_name); ixgbevf_wq = create_singlethread_workqueue(ixgbevf_driver_name);
@@ -4886,7 +4888,13 @@ static int __init ixgbevf_init_module(void)
return -ENOMEM; return -ENOMEM;
} }
return pci_register_driver(&ixgbevf_driver); err = pci_register_driver(&ixgbevf_driver);
if (err) {
destroy_workqueue(ixgbevf_wq);
return err;
}
return 0;
} }
module_init(ixgbevf_init_module); module_init(ixgbevf_init_module);