Merge tag 'drm-intel-next-2019-03-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
UAPI Changes: - Report an error early instead of SIGBUS later when mmap beyond BO size Core Changes: - This includes backmerge of drm-next and two merges of Maarten's topic/hdr-formats Driver Changes: - Add Comet Lake (Gen9) PCI IDs to Coffee Lake ID list (Anusha) - Add missing ICL PCI ID (Jose) - Fix legacy gamma mode for ICL (Ville) - Assume eDP is present on port A when there is no VBT (Thomas) - Corrections to eDP training patterns (Jose) - Fix PSR2 selective update corruption after PSR1 setup (Jose) - Fix CRC mismatch error for DP link layer compliance (Aditya) - Fix CNL DPLL readout and clean up code (Ville) - Turn off the CUS when turning off a HDR plane (Ville) - Avoid a race with execlist tasklet during race (Chris) - Add missing CSC readout and clean up code (Ville) - Avoid unnecessary wakeref during debugfs/drop_caches/set (Chris, Caz) - Hold references to ring/HW context/context explicitly when used (Chris) - Assume next platforms inherit old platform (Rodrigo) - Use HWS indices rather than addresses for breadcrumbs (Chris) - Add REG_BIT/REG_GENMASK and REG_FIELD_PREP macros (Jani) - Convert crept in C99 types to kernel fixed size types (Jani) - Avoid passing full dev_priv in forcewake functions (Daniele) - Reset GuC on GPU reset (Sujaritha) - Rework MG and Combo PLLs to vfuncs (Lucas) - Explicitly track ppGTT size (Chris, Bob) - Coding style improvements and code modularization (Ville) - Selftest and debugging improvements (Chris) Signed-off-by: Dave Airlie <airlied@redhat.com> # Conflicts: # drivers/gpu/drm/i915/intel_hdmi.c From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190325124925.GA12726@jlahtine-desk.ger.corp.intel.com
This commit is contained in:
@@ -102,7 +102,7 @@ static bool pmu_needs_timer(struct drm_i915_private *i915, bool gpu_active)
|
||||
*
|
||||
* Use RCS as proxy for all engines.
|
||||
*/
|
||||
else if (intel_engine_supports_stats(i915->engine[RCS]))
|
||||
else if (intel_engine_supports_stats(i915->engine[RCS0]))
|
||||
enable &= ~BIT(I915_SAMPLE_BUSY);
|
||||
|
||||
/*
|
||||
@@ -149,14 +149,6 @@ void i915_pmu_gt_unparked(struct drm_i915_private *i915)
|
||||
spin_unlock_irq(&i915->pmu.lock);
|
||||
}
|
||||
|
||||
static bool grab_forcewake(struct drm_i915_private *i915, bool fw)
|
||||
{
|
||||
if (!fw)
|
||||
intel_uncore_forcewake_get(i915, FORCEWAKE_ALL);
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
static void
|
||||
add_sample(struct i915_pmu_sample *sample, u32 val)
|
||||
{
|
||||
@@ -169,49 +161,48 @@ engines_sample(struct drm_i915_private *dev_priv, unsigned int period_ns)
|
||||
struct intel_engine_cs *engine;
|
||||
enum intel_engine_id id;
|
||||
intel_wakeref_t wakeref;
|
||||
bool fw = false;
|
||||
unsigned long flags;
|
||||
|
||||
if ((dev_priv->pmu.enable & ENGINE_SAMPLE_MASK) == 0)
|
||||
return;
|
||||
|
||||
if (!dev_priv->gt.awake)
|
||||
return;
|
||||
|
||||
wakeref = intel_runtime_pm_get_if_in_use(dev_priv);
|
||||
wakeref = 0;
|
||||
if (READ_ONCE(dev_priv->gt.awake))
|
||||
wakeref = intel_runtime_pm_get_if_in_use(dev_priv);
|
||||
if (!wakeref)
|
||||
return;
|
||||
|
||||
spin_lock_irqsave(&dev_priv->uncore.lock, flags);
|
||||
for_each_engine(engine, dev_priv, id) {
|
||||
u32 current_seqno = intel_engine_get_seqno(engine);
|
||||
u32 last_seqno = intel_engine_last_submit(engine);
|
||||
struct intel_engine_pmu *pmu = &engine->pmu;
|
||||
bool busy;
|
||||
u32 val;
|
||||
|
||||
val = !i915_seqno_passed(current_seqno, last_seqno);
|
||||
|
||||
if (val)
|
||||
add_sample(&engine->pmu.sample[I915_SAMPLE_BUSY],
|
||||
period_ns);
|
||||
|
||||
if (val && (engine->pmu.enable &
|
||||
(BIT(I915_SAMPLE_WAIT) | BIT(I915_SAMPLE_SEMA)))) {
|
||||
fw = grab_forcewake(dev_priv, fw);
|
||||
|
||||
val = I915_READ_FW(RING_CTL(engine->mmio_base));
|
||||
} else {
|
||||
val = 0;
|
||||
}
|
||||
val = I915_READ_FW(RING_CTL(engine->mmio_base));
|
||||
if (val == 0) /* powerwell off => engine idle */
|
||||
continue;
|
||||
|
||||
if (val & RING_WAIT)
|
||||
add_sample(&engine->pmu.sample[I915_SAMPLE_WAIT],
|
||||
period_ns);
|
||||
|
||||
add_sample(&pmu->sample[I915_SAMPLE_WAIT], period_ns);
|
||||
if (val & RING_WAIT_SEMAPHORE)
|
||||
add_sample(&engine->pmu.sample[I915_SAMPLE_SEMA],
|
||||
period_ns);
|
||||
}
|
||||
add_sample(&pmu->sample[I915_SAMPLE_SEMA], period_ns);
|
||||
|
||||
if (fw)
|
||||
intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL);
|
||||
/*
|
||||
* While waiting on a semaphore or event, MI_MODE reports the
|
||||
* ring as idle. However, previously using the seqno, and with
|
||||
* execlists sampling, we account for the ring waiting as the
|
||||
* engine being busy. Therefore, we record the sample as being
|
||||
* busy if either waiting or !idle.
|
||||
*/
|
||||
busy = val & (RING_WAIT_SEMAPHORE | RING_WAIT);
|
||||
if (!busy) {
|
||||
val = I915_READ_FW(RING_MI_MODE(engine->mmio_base));
|
||||
busy = !(val & MODE_IDLE);
|
||||
}
|
||||
if (busy)
|
||||
add_sample(&pmu->sample[I915_SAMPLE_BUSY], period_ns);
|
||||
}
|
||||
spin_unlock_irqrestore(&dev_priv->uncore.lock, flags);
|
||||
|
||||
intel_runtime_pm_put(dev_priv, wakeref);
|
||||
}
|
||||
|
Reference in New Issue
Block a user