xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: stm32-dcmi: simplify of_node_put usage

Browse Source 
This does not fix any bug - this is just a code simplification. As
np is not used after passing it to v4l2_fwnode_endpoint_parse() its
refcount can be decremented immediately and at one location.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Nicholas Mc Guire
2018-06-12 13:23:16 -04:00
committed by Mauro Carvalho Chehab
parent c2ee2243ce
commit f11552d030
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/media/platform/stm32/stm32-dcmi.c
View File

@@ -1655,23 +1655,20 @@ static int dcmi_probe(struct platform_device *pdev)
} }
ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(np), &ep); ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(np), &ep);
of_node_put(np);
if (ret) { if (ret) {
dev_err(&pdev->dev, "Could not parse the endpoint\n"); dev_err(&pdev->dev, "Could not parse the endpoint\n");
of_node_put(np);
return -ENODEV; return -ENODEV;
} }
if (ep.bus_type == V4L2_MBUS_CSI2) { if (ep.bus_type == V4L2_MBUS_CSI2) {
dev_err(&pdev->dev, "CSI bus not supported\n"); dev_err(&pdev->dev, "CSI bus not supported\n");
of_node_put(np);
return -ENODEV; return -ENODEV;
} }
dcmi->bus.flags = ep.bus.parallel.flags; dcmi->bus.flags = ep.bus.parallel.flags;
dcmi->bus.bus_width = ep.bus.parallel.bus_width; dcmi->bus.bus_width = ep.bus.parallel.bus_width;
dcmi->bus.data_shift = ep.bus.parallel.data_shift; dcmi->bus.data_shift = ep.bus.parallel.data_shift;
of_node_put(np);
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (irq <= 0) { if (irq <= 0) {
dev_err(&pdev->dev, "Could not get irq\n"); dev_err(&pdev->dev, "Could not get irq\n");