xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds

Browse Source 
[ Upstream commit 1c4a4a4c8410be4a231a58b23e7a30923ff954ac ]

When building with automatic stack variable initialization, GCC 12
complains about variables defined outside of switch case statements.
Move the variable into the case that uses it, which silences the warning:

arch/powerpc/xmon/xmon.c: In function ‘bpt_cmds’:
arch/powerpc/xmon/xmon.c:1529:13: warning: statement will never be executed [-Wswitch-unreachable]
 1529 |         int mode;
      |             ^~~~

Fixes: 09b6c1129f ("powerpc/xmon: Fix compile error with PPC_8xx=y")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/YySE6FHiOcbWWR+9@work
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Gustavo A. R. Silva
2022-09-16 15:15:04 +01:00
committed by Greg Kroah-Hartman
parent 76957b6aed
commit f0bd6504e5
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
arch/powerpc/xmon/xmon.c
View File

@@ -1433,9 +1433,9 @@ bpt_cmds(void)
cmd = inchar(); cmd = inchar();
switch (cmd) { switch (cmd) {
static const char badaddr[] = "Only kernel addresses are permitted for breakpoints\n"; case 'd': { /* bd - hardware data breakpoint */
int mode; static const char badaddr[] = "Only kernel addresses are permitted for breakpoints\n";
case 'd': /* bd - hardware data breakpoint */ int mode;
if (xmon_is_ro) { if (xmon_is_ro) {
printf(xmon_ro_msg); printf(xmon_ro_msg);
break; break;
@@ -1468,6 +1468,7 @@ bpt_cmds(void)
force_enable_xmon(); force_enable_xmon();
break; break;
}
case 'i': /* bi - hardware instr breakpoint */ case 'i': /* bi - hardware instr breakpoint */
if (xmon_is_ro) { if (xmon_is_ro) {