scsi: remove ->change_queue_type method
Since we got rid of ordered tag support in 2010 the prime use case of switching on and off ordered tags has been obsolete. The other function of enabling/disabling tagging entirely has only been correctly implemented by the 53c700 driver and isn't generally useful. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com Reviewed-by: Hannes Reinecke <hare@suse.de>
This commit is contained in:
@@ -4987,32 +4987,6 @@ sdebug_change_qdepth(struct scsi_device *sdev, int qdepth)
|
||||
return sdev->queue_depth;
|
||||
}
|
||||
|
||||
static int
|
||||
sdebug_change_qtype(struct scsi_device *sdev, int qtype)
|
||||
{
|
||||
qtype = scsi_change_queue_type(sdev, qtype);
|
||||
if (SCSI_DEBUG_OPT_Q_NOISE & scsi_debug_opts) {
|
||||
const char *cp;
|
||||
|
||||
switch (qtype) {
|
||||
case 0:
|
||||
cp = "untagged";
|
||||
break;
|
||||
case MSG_SIMPLE_TAG:
|
||||
cp = "simple tags";
|
||||
break;
|
||||
case MSG_ORDERED_TAG:
|
||||
cp = "ordered tags";
|
||||
break;
|
||||
default:
|
||||
cp = "unknown";
|
||||
break;
|
||||
}
|
||||
sdev_printk(KERN_INFO, sdev, "%s: to %s\n", __func__, cp);
|
||||
}
|
||||
return qtype;
|
||||
}
|
||||
|
||||
static int
|
||||
check_inject(struct scsi_cmnd *scp)
|
||||
{
|
||||
@@ -5212,7 +5186,6 @@ static struct scsi_host_template sdebug_driver_template = {
|
||||
.ioctl = scsi_debug_ioctl,
|
||||
.queuecommand = sdebug_queuecommand_lock_or_not,
|
||||
.change_queue_depth = sdebug_change_qdepth,
|
||||
.change_queue_type = sdebug_change_qtype,
|
||||
.eh_abort_handler = scsi_debug_abort,
|
||||
.eh_device_reset_handler = scsi_debug_device_reset,
|
||||
.eh_target_reset_handler = scsi_debug_target_reset,
|
||||
|
Reference in New Issue
Block a user