xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UBI: always dump flash contents in case of errors

Browse Source 
UBI (and UBIFS) are a bit over-engineered WRT debugging. The idea was to
link as few as possible when debugging is disabled, but the downside is
that most people produce bug reports which are difficult to understand.

Always dump the flash contents in case of errors, not only when debugging is
enabled.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
This commit is contained in:
Artem Bityutskiy
2012-04-24 07:10:33 +03:00
committed by Artem Bityutskiy
parent 25886a368d
commit ef7088e7f8
4 changed files with 40 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/mtd/ubi/io.c
View File

@@ -294,7 +294,7 @@ int ubi_io_write(struct ubi_device *ubi, const void *buf, int pnum, int offset,
ubi_err("error %d while writing %d bytes to PEB %d:%d, written "
"%zd bytes", err, len, pnum, offset, written);
dump_stack();
ubi_dbg_dump_flash(ubi, pnum, offset, len);
ubi_dump_flash(ubi, pnum, offset, len);
} else
ubi_assert(written == len);
@@ -563,7 +563,7 @@ static int nor_erase_prepare(struct ubi_device *ubi, int pnum)
*/
ubi_err("cannot invalidate PEB %d, write returned %d read returned %d",
pnum, err, err1);
ubi_dbg_dump_flash(ubi, pnum, 0, ubi->peb_size);
ubi_dump_flash(ubi, pnum, 0, ubi->peb_size);
return -EIO;
}