powerpc: Remove all usages of NO_IRQ
NO_IRQ has been == 0 on powerpc for just over ten years (since commit
0ebfff1491
("[POWERPC] Add new interrupt mapping core and change
platforms to use it")). It's also 0 on most other arches.
Although it's fairly harmless, every now and then it causes confusion
when a driver is built on powerpc and another arch which doesn't define
NO_IRQ. There's at least 6 definitions of NO_IRQ in drivers/, at least
some of which are to work around that problem.
So we'd like to remove it. This is fairly trivial in the arch code, we
just convert:
if (irq == NO_IRQ) to if (!irq)
if (irq != NO_IRQ) to if (irq)
irq = NO_IRQ; to irq = 0;
return NO_IRQ; to return 0;
And a few other odd cases as well.
At least for now we keep the #define NO_IRQ, because there is driver
code that uses NO_IRQ and the fixes to remove those will go via other
trees.
Note we also change some occurrences in PPC sound drivers, drivers/ps3,
and drivers/macintosh.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
@@ -236,7 +236,7 @@ static void macio_create_fixup_irq(struct macio_dev *dev, int index,
|
||||
unsigned int irq;
|
||||
|
||||
irq = irq_create_mapping(NULL, line);
|
||||
if (irq != NO_IRQ) {
|
||||
if (!irq) {
|
||||
dev->interrupt[index].start = irq;
|
||||
dev->interrupt[index].flags = IORESOURCE_IRQ;
|
||||
dev->interrupt[index].name = dev_name(&dev->ofdev.dev);
|
||||
@@ -299,7 +299,7 @@ static void macio_setup_interrupts(struct macio_dev *dev)
|
||||
break;
|
||||
res = &dev->interrupt[j];
|
||||
irq = irq_of_parse_and_map(np, i++);
|
||||
if (irq == NO_IRQ)
|
||||
if (!irq)
|
||||
break;
|
||||
res->start = irq;
|
||||
res->flags = IORESOURCE_IRQ;
|
||||
|
Reference in New Issue
Block a user