xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[POWERPC] mpic_pasemi_msi: Failed allocation unnoticed

Browse Source 
bitmap_find_free_region(), called by mpic_msi_alloc_hwirqs() may return
signed, but hwirq is unsigned.  A failed allocation remains unnoticed.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Roel Kluin
2008-04-24 08:32:26 +10:00
committed by Paul Mackerras
parent 54ef0ec22a
commit ee1a08f963
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
arch/powerpc/sysdev/mpic_pasemi_msi.c
View File

@@ -95,6 +95,7 @@ static int pasemi_msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
unsigned int virq; unsigned int virq;
struct msi_desc *entry; struct msi_desc *entry;
struct msi_msg msg; struct msi_msg msg;
int ret;
pr_debug("pasemi_msi_setup_msi_irqs, pdev %p nvec %d type %d\n", pr_debug("pasemi_msi_setup_msi_irqs, pdev %p nvec %d type %d\n",
pdev, nvec, type); pdev, nvec, type);
@@ -108,8 +109,9 @@ static int pasemi_msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
* few MSIs for someone, but restrictions will apply to how the * few MSIs for someone, but restrictions will apply to how the
* sources can be changed independently. * sources can be changed independently.
*/ */
hwirq = mpic_msi_alloc_hwirqs(msi_mpic, ALLOC_CHUNK); ret = mpic_msi_alloc_hwirqs(msi_mpic, ALLOC_CHUNK);
if (hwirq < 0) { hwirq = ret;
if (ret < 0) {
pr_debug("pasemi_msi: failed allocating hwirq\n"); pr_debug("pasemi_msi: failed allocating hwirq\n");
return hwirq; return hwirq;
} }