Merge branch 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
* 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip: perf session: Make events_stats u64 to avoid overflow on 32-bit arches hw-breakpoints: Fix hardware breakpoints -> perf events dependency perf events: Dont report side-band events on each cpu for per-task-per-cpu events perf events, x86/stacktrace: Fix performance/softlockup by providing a special frame pointer-only stack walker perf events, x86/stacktrace: Make stack walking optional perf events: Remove unused perf_counter.h header file perf probe: Check new event name kprobe-tracer: Check new event/group name perf probe: Check whether debugfs path is correct perf probe: Fix libdwarf include path for Debian
This commit is contained in:
@@ -1381,6 +1381,9 @@ static void perf_ctx_adjust_freq(struct perf_event_context *ctx)
|
||||
if (event->state != PERF_EVENT_STATE_ACTIVE)
|
||||
continue;
|
||||
|
||||
if (event->cpu != -1 && event->cpu != smp_processor_id())
|
||||
continue;
|
||||
|
||||
hwc = &event->hw;
|
||||
|
||||
interrupts = hwc->interrupts;
|
||||
@@ -3265,6 +3268,9 @@ static void perf_event_task_output(struct perf_event *event,
|
||||
|
||||
static int perf_event_task_match(struct perf_event *event)
|
||||
{
|
||||
if (event->cpu != -1 && event->cpu != smp_processor_id())
|
||||
return 0;
|
||||
|
||||
if (event->attr.comm || event->attr.mmap || event->attr.task)
|
||||
return 1;
|
||||
|
||||
@@ -3290,12 +3296,11 @@ static void perf_event_task_event(struct perf_task_event *task_event)
|
||||
rcu_read_lock();
|
||||
cpuctx = &get_cpu_var(perf_cpu_context);
|
||||
perf_event_task_ctx(&cpuctx->ctx, task_event);
|
||||
put_cpu_var(perf_cpu_context);
|
||||
|
||||
if (!ctx)
|
||||
ctx = rcu_dereference(task_event->task->perf_event_ctxp);
|
||||
if (ctx)
|
||||
perf_event_task_ctx(ctx, task_event);
|
||||
put_cpu_var(perf_cpu_context);
|
||||
rcu_read_unlock();
|
||||
}
|
||||
|
||||
@@ -3372,6 +3377,9 @@ static void perf_event_comm_output(struct perf_event *event,
|
||||
|
||||
static int perf_event_comm_match(struct perf_event *event)
|
||||
{
|
||||
if (event->cpu != -1 && event->cpu != smp_processor_id())
|
||||
return 0;
|
||||
|
||||
if (event->attr.comm)
|
||||
return 1;
|
||||
|
||||
@@ -3408,15 +3416,10 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event)
|
||||
rcu_read_lock();
|
||||
cpuctx = &get_cpu_var(perf_cpu_context);
|
||||
perf_event_comm_ctx(&cpuctx->ctx, comm_event);
|
||||
put_cpu_var(perf_cpu_context);
|
||||
|
||||
/*
|
||||
* doesn't really matter which of the child contexts the
|
||||
* events ends up in.
|
||||
*/
|
||||
ctx = rcu_dereference(current->perf_event_ctxp);
|
||||
if (ctx)
|
||||
perf_event_comm_ctx(ctx, comm_event);
|
||||
put_cpu_var(perf_cpu_context);
|
||||
rcu_read_unlock();
|
||||
}
|
||||
|
||||
@@ -3491,6 +3494,9 @@ static void perf_event_mmap_output(struct perf_event *event,
|
||||
static int perf_event_mmap_match(struct perf_event *event,
|
||||
struct perf_mmap_event *mmap_event)
|
||||
{
|
||||
if (event->cpu != -1 && event->cpu != smp_processor_id())
|
||||
return 0;
|
||||
|
||||
if (event->attr.mmap)
|
||||
return 1;
|
||||
|
||||
@@ -3564,15 +3570,10 @@ got_name:
|
||||
rcu_read_lock();
|
||||
cpuctx = &get_cpu_var(perf_cpu_context);
|
||||
perf_event_mmap_ctx(&cpuctx->ctx, mmap_event);
|
||||
put_cpu_var(perf_cpu_context);
|
||||
|
||||
/*
|
||||
* doesn't really matter which of the child contexts the
|
||||
* events ends up in.
|
||||
*/
|
||||
ctx = rcu_dereference(current->perf_event_ctxp);
|
||||
if (ctx)
|
||||
perf_event_mmap_ctx(ctx, mmap_event);
|
||||
put_cpu_var(perf_cpu_context);
|
||||
rcu_read_unlock();
|
||||
|
||||
kfree(buf);
|
||||
@@ -3863,6 +3864,9 @@ static int perf_swevent_match(struct perf_event *event,
|
||||
struct perf_sample_data *data,
|
||||
struct pt_regs *regs)
|
||||
{
|
||||
if (event->cpu != -1 && event->cpu != smp_processor_id())
|
||||
return 0;
|
||||
|
||||
if (!perf_swevent_is_counting(event))
|
||||
return 0;
|
||||
|
||||
|
@@ -282,6 +282,18 @@ static int kprobe_dispatcher(struct kprobe *kp, struct pt_regs *regs);
|
||||
static int kretprobe_dispatcher(struct kretprobe_instance *ri,
|
||||
struct pt_regs *regs);
|
||||
|
||||
/* Check the name is good for event/group */
|
||||
static int check_event_name(const char *name)
|
||||
{
|
||||
if (!isalpha(*name) && *name != '_')
|
||||
return 0;
|
||||
while (*++name != '\0') {
|
||||
if (!isalpha(*name) && !isdigit(*name) && *name != '_')
|
||||
return 0;
|
||||
}
|
||||
return 1;
|
||||
}
|
||||
|
||||
/*
|
||||
* Allocate new trace_probe and initialize it (including kprobes).
|
||||
*/
|
||||
@@ -293,10 +305,11 @@ static struct trace_probe *alloc_trace_probe(const char *group,
|
||||
int nargs, int is_return)
|
||||
{
|
||||
struct trace_probe *tp;
|
||||
int ret = -ENOMEM;
|
||||
|
||||
tp = kzalloc(SIZEOF_TRACE_PROBE(nargs), GFP_KERNEL);
|
||||
if (!tp)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
return ERR_PTR(ret);
|
||||
|
||||
if (symbol) {
|
||||
tp->symbol = kstrdup(symbol, GFP_KERNEL);
|
||||
@@ -312,14 +325,20 @@ static struct trace_probe *alloc_trace_probe(const char *group,
|
||||
else
|
||||
tp->rp.kp.pre_handler = kprobe_dispatcher;
|
||||
|
||||
if (!event)
|
||||
if (!event || !check_event_name(event)) {
|
||||
ret = -EINVAL;
|
||||
goto error;
|
||||
}
|
||||
|
||||
tp->call.name = kstrdup(event, GFP_KERNEL);
|
||||
if (!tp->call.name)
|
||||
goto error;
|
||||
|
||||
if (!group)
|
||||
if (!group || !check_event_name(group)) {
|
||||
ret = -EINVAL;
|
||||
goto error;
|
||||
}
|
||||
|
||||
tp->call.system = kstrdup(group, GFP_KERNEL);
|
||||
if (!tp->call.system)
|
||||
goto error;
|
||||
@@ -330,7 +349,7 @@ error:
|
||||
kfree(tp->call.name);
|
||||
kfree(tp->symbol);
|
||||
kfree(tp);
|
||||
return ERR_PTR(-ENOMEM);
|
||||
return ERR_PTR(ret);
|
||||
}
|
||||
|
||||
static void free_probe_arg(struct probe_arg *arg)
|
||||
@@ -695,10 +714,10 @@ static int create_trace_probe(int argc, char **argv)
|
||||
if (!event) {
|
||||
/* Make a new event name */
|
||||
if (symbol)
|
||||
snprintf(buf, MAX_EVENT_NAME_LEN, "%c@%s%+ld",
|
||||
snprintf(buf, MAX_EVENT_NAME_LEN, "%c_%s_%ld",
|
||||
is_return ? 'r' : 'p', symbol, offset);
|
||||
else
|
||||
snprintf(buf, MAX_EVENT_NAME_LEN, "%c@0x%p",
|
||||
snprintf(buf, MAX_EVENT_NAME_LEN, "%c_0x%p",
|
||||
is_return ? 'r' : 'p', addr);
|
||||
event = buf;
|
||||
}
|
||||
|
@@ -93,6 +93,7 @@ static const struct stacktrace_ops backtrace_ops = {
|
||||
.warning_symbol = backtrace_warning_symbol,
|
||||
.stack = backtrace_stack,
|
||||
.address = backtrace_address,
|
||||
.walk_stack = print_context_stack,
|
||||
};
|
||||
|
||||
static int
|
||||
|
Reference in New Issue
Block a user