hwmon: (abituguru) Depend on DMI
The abituguru drivers are only built on X86, where DMI support is now enabled by default. So let these drivers depend on DMI, for the following gains: * Robustness and safety. Detection of these devices is weak and uses non-standard methods, it should really be limited to Abit boards unless the user explicitly asks otherwise. * Code simplicity. The code is easier to read without ifdefs. * Better build testing coverage. Now there's only one way to build the drivers, so no risk of build failure on exotic systems. Signed-off-by: Jean Delvare <khali@linux-fr.org> Acked-by: Guenter Roeck <guenter.roeck@ericsson.com> Acked-by: Alistair John Strachan <alistair@devzero.co.uk> Acked-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:

committed by
Jean Delvare

parent
5b0380c94a
commit
ec693fe528
@@ -1119,8 +1119,6 @@ static struct platform_driver abituguru3_driver = {
|
||||
.resume = abituguru3_resume
|
||||
};
|
||||
|
||||
#ifdef CONFIG_DMI
|
||||
|
||||
static int __init abituguru3_dmi_detect(void)
|
||||
{
|
||||
const char *board_vendor, *board_name;
|
||||
@@ -1159,15 +1157,6 @@ static int __init abituguru3_dmi_detect(void)
|
||||
return 1;
|
||||
}
|
||||
|
||||
#else /* !CONFIG_DMI */
|
||||
|
||||
static inline int abituguru3_dmi_detect(void)
|
||||
{
|
||||
return 1;
|
||||
}
|
||||
|
||||
#endif /* CONFIG_DMI */
|
||||
|
||||
/* FIXME: Manual detection should die eventually; we need to collect stable
|
||||
* DMI model names first before we can rely entirely on CONFIG_DMI.
|
||||
*/
|
||||
@@ -1216,10 +1205,8 @@ static int __init abituguru3_init(void)
|
||||
if (err)
|
||||
return err;
|
||||
|
||||
#ifdef CONFIG_DMI
|
||||
pr_warn("this motherboard was not detected using DMI. "
|
||||
"Please send the output of \"dmidecode\" to the abituguru3 maintainer (see MAINTAINERS)\n");
|
||||
#endif
|
||||
}
|
||||
|
||||
err = platform_driver_register(&abituguru3_driver);
|
||||
|
Reference in New Issue
Block a user