xfs remove the XFS_TRANS_DEBUG routines
Remove the XFS_TRANS_DEBUG routines. They are no longer appropriate and have not been used in years Signed-off-by: Mark Tinguely <tinguely@sgi.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Ben Myers <bpm@sgi.com>
This commit is contained in:
@@ -37,109 +37,6 @@ static inline struct xfs_buf_log_item *BUF_ITEM(struct xfs_log_item *lip)
|
||||
return container_of(lip, struct xfs_buf_log_item, bli_item);
|
||||
}
|
||||
|
||||
|
||||
#ifdef XFS_TRANS_DEBUG
|
||||
/*
|
||||
* This function uses an alternate strategy for tracking the bytes
|
||||
* that the user requests to be logged. This can then be used
|
||||
* in conjunction with the bli_orig array in the buf log item to
|
||||
* catch bugs in our callers' code.
|
||||
*
|
||||
* We also double check the bits set in xfs_buf_item_log using a
|
||||
* simple algorithm to check that every byte is accounted for.
|
||||
*/
|
||||
STATIC void
|
||||
xfs_buf_item_log_debug(
|
||||
xfs_buf_log_item_t *bip,
|
||||
uint first,
|
||||
uint last)
|
||||
{
|
||||
uint x;
|
||||
uint byte;
|
||||
uint nbytes;
|
||||
uint chunk_num;
|
||||
uint word_num;
|
||||
uint bit_num;
|
||||
uint bit_set;
|
||||
uint *wordp;
|
||||
|
||||
ASSERT(bip->bli_logged != NULL);
|
||||
byte = first;
|
||||
nbytes = last - first + 1;
|
||||
bfset(bip->bli_logged, first, nbytes);
|
||||
for (x = 0; x < nbytes; x++) {
|
||||
chunk_num = byte >> XFS_BLF_SHIFT;
|
||||
word_num = chunk_num >> BIT_TO_WORD_SHIFT;
|
||||
bit_num = chunk_num & (NBWORD - 1);
|
||||
wordp = &(bip->__bli_format.blf_data_map[word_num]);
|
||||
bit_set = *wordp & (1 << bit_num);
|
||||
ASSERT(bit_set);
|
||||
byte++;
|
||||
}
|
||||
}
|
||||
|
||||
/*
|
||||
* This function is called when we flush something into a buffer without
|
||||
* logging it. This happens for things like inodes which are logged
|
||||
* separately from the buffer.
|
||||
*/
|
||||
void
|
||||
xfs_buf_item_flush_log_debug(
|
||||
xfs_buf_t *bp,
|
||||
uint first,
|
||||
uint last)
|
||||
{
|
||||
xfs_buf_log_item_t *bip = bp->b_fspriv;
|
||||
uint nbytes;
|
||||
|
||||
if (bip == NULL || (bip->bli_item.li_type != XFS_LI_BUF))
|
||||
return;
|
||||
|
||||
ASSERT(bip->bli_logged != NULL);
|
||||
nbytes = last - first + 1;
|
||||
bfset(bip->bli_logged, first, nbytes);
|
||||
}
|
||||
|
||||
/*
|
||||
* This function is called to verify that our callers have logged
|
||||
* all the bytes that they changed.
|
||||
*
|
||||
* It does this by comparing the original copy of the buffer stored in
|
||||
* the buf log item's bli_orig array to the current copy of the buffer
|
||||
* and ensuring that all bytes which mismatch are set in the bli_logged
|
||||
* array of the buf log item.
|
||||
*/
|
||||
STATIC void
|
||||
xfs_buf_item_log_check(
|
||||
xfs_buf_log_item_t *bip)
|
||||
{
|
||||
char *orig;
|
||||
char *buffer;
|
||||
int x;
|
||||
xfs_buf_t *bp;
|
||||
|
||||
ASSERT(bip->bli_orig != NULL);
|
||||
ASSERT(bip->bli_logged != NULL);
|
||||
|
||||
bp = bip->bli_buf;
|
||||
ASSERT(bp->b_length > 0);
|
||||
ASSERT(bp->b_addr != NULL);
|
||||
orig = bip->bli_orig;
|
||||
buffer = bp->b_addr;
|
||||
for (x = 0; x < BBTOB(bp->b_length); x++) {
|
||||
if (orig[x] != buffer[x] && !btst(bip->bli_logged, x)) {
|
||||
xfs_emerg(bp->b_mount,
|
||||
"%s: bip %x buffer %x orig %x index %d",
|
||||
__func__, bip, bp, orig, x);
|
||||
ASSERT(0);
|
||||
}
|
||||
}
|
||||
}
|
||||
#else
|
||||
#define xfs_buf_item_log_debug(x,y,z)
|
||||
#define xfs_buf_item_log_check(x)
|
||||
#endif
|
||||
|
||||
STATIC void xfs_buf_do_callbacks(struct xfs_buf *bp);
|
||||
|
||||
/*
|
||||
@@ -429,7 +326,6 @@ xfs_buf_item_format(
|
||||
* Check to make sure everything is consistent.
|
||||
*/
|
||||
trace_xfs_buf_item_format(bip);
|
||||
xfs_buf_item_log_check(bip);
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -915,8 +811,6 @@ xfs_buf_item_log_segment(
|
||||
mask = (1 << end_bit) - 1;
|
||||
*wordp |= mask;
|
||||
}
|
||||
|
||||
xfs_buf_item_log_debug(bip, first, last);
|
||||
}
|
||||
|
||||
/*
|
||||
|
Reference in New Issue
Block a user