xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xfs: more sensible inode refcounting for ialloc

Browse Source 
Currently we return iodes from xfs_ialloc with just a single reference held.
But we need two references, as one is dropped during transaction commit and
the second needs to be transfered to the VFS.  Change xfs_ialloc to use
xfs_iget plus xfs_trans_ijoin_ref to grab two references to the inode,
and remove the now superflous IHOLD calls from all callers.  This also
greatly simplifies the error handling in xfs_create and also allow to remove
xfs_trans_iget as no other callers are left.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
This commit is contained in:
Christoph Hellwig
2011-02-13 13:26:42 +00:00
committed by Alex Elder
parent 1050c71e29
commit ec3ba85f40
5 changed files with 20 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/xfs/quota/xfs_qm.c
View File

@@ -1229,13 +1229,6 @@ xfs_qm_qino_alloc(
return error;
}
/*
* Keep an extra reference to this quota inode. This inode is
* locked exclusively and joined to the transaction already.
*/
ASSERT(xfs_isilocked(*ip, XFS_ILOCK_EXCL));
IHOLD(*ip);
/*
* Make the changes in the superblock, and log those too.
* sbfields arg may contain fields other than *QUOTINO;