module_param: make bool parameters really bool (net & drivers/net)
module_param(bool) used to counter-intuitively take an int. In
fddd5201
(mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
(Thanks to Joe Perches for suggesting coccinelle for 0/1 -> true/false).
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
3db1cd5c05
commit
eb93992207
@@ -29,7 +29,7 @@
|
||||
|
||||
|
||||
#ifdef CONFIG_IP_DCCP_CCID2_DEBUG
|
||||
static int ccid2_debug;
|
||||
static bool ccid2_debug;
|
||||
#define ccid2_pr_debug(format, a...) DCCP_PR_DEBUG(ccid2_debug, format, ##a)
|
||||
#else
|
||||
#define ccid2_pr_debug(format, a...)
|
||||
@@ -174,7 +174,7 @@ out:
|
||||
/*
|
||||
* Congestion window validation (RFC 2861).
|
||||
*/
|
||||
static int ccid2_do_cwv = 1;
|
||||
static bool ccid2_do_cwv = true;
|
||||
module_param(ccid2_do_cwv, bool, 0644);
|
||||
MODULE_PARM_DESC(ccid2_do_cwv, "Perform RFC2861 Congestion Window Validation");
|
||||
|
||||
|
@@ -38,7 +38,7 @@
|
||||
#include <asm/unaligned.h>
|
||||
|
||||
#ifdef CONFIG_IP_DCCP_CCID3_DEBUG
|
||||
static int ccid3_debug;
|
||||
static bool ccid3_debug;
|
||||
#define ccid3_pr_debug(format, a...) DCCP_PR_DEBUG(ccid3_debug, format, ##a)
|
||||
#else
|
||||
#define ccid3_pr_debug(format, a...)
|
||||
|
@@ -8,7 +8,7 @@
|
||||
#include "tfrc.h"
|
||||
|
||||
#ifdef CONFIG_IP_DCCP_TFRC_DEBUG
|
||||
int tfrc_debug;
|
||||
bool tfrc_debug;
|
||||
module_param(tfrc_debug, bool, 0644);
|
||||
MODULE_PARM_DESC(tfrc_debug, "Enable TFRC debug messages");
|
||||
#endif
|
||||
|
@@ -21,7 +21,7 @@
|
||||
#include "packet_history.h"
|
||||
|
||||
#ifdef CONFIG_IP_DCCP_TFRC_DEBUG
|
||||
extern int tfrc_debug;
|
||||
extern bool tfrc_debug;
|
||||
#define tfrc_pr_debug(format, a...) DCCP_PR_DEBUG(tfrc_debug, format, ##a)
|
||||
#else
|
||||
#define tfrc_pr_debug(format, a...)
|
||||
|
@@ -39,7 +39,7 @@
|
||||
"%s: " fmt, __func__, ##a)
|
||||
|
||||
#ifdef CONFIG_IP_DCCP_DEBUG
|
||||
extern int dccp_debug;
|
||||
extern bool dccp_debug;
|
||||
#define dccp_pr_debug(format, a...) DCCP_PR_DEBUG(dccp_debug, format, ##a)
|
||||
#define dccp_pr_debug_cat(format, a...) DCCP_PRINTK(dccp_debug, format, ##a)
|
||||
#define dccp_debug(fmt, a...) dccp_pr_debug_cat(KERN_DEBUG fmt, ##a)
|
||||
|
@@ -1099,7 +1099,7 @@ module_param(thash_entries, int, 0444);
|
||||
MODULE_PARM_DESC(thash_entries, "Number of ehash buckets");
|
||||
|
||||
#ifdef CONFIG_IP_DCCP_DEBUG
|
||||
int dccp_debug;
|
||||
bool dccp_debug;
|
||||
module_param(dccp_debug, bool, 0644);
|
||||
MODULE_PARM_DESC(dccp_debug, "Enable debug messages");
|
||||
|
||||
|
Reference in New Issue
Block a user