xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cpufreq: Remove extra variables from cpufreq_add_dev_symlink()

Browse Source 
We call cpufreq_cpu_get() in cpufreq_add_dev_symlink() to increase usage
refcount of policy, but not to get a policy for the given CPU.  So, we
don't really need to capture the return value of this routine.  We can
simply use policy passed as an argument to cpufreq_add_dev_symlink().

Moreover debug print is rewritten to make it more clear.

[rjw: Changelog]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Viresh Kumar
2013-07-31 14:31:33 +02:00
committed by Rafael J. Wysocki
parent 5302c3fb2e
commit e8fdde1011
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/cpufreq/cpufreq.c
View File

@@ -813,19 +813,18 @@ static int cpufreq_add_dev_symlink(unsigned int cpu,
int ret = 0; int ret = 0;
for_each_cpu(j, policy->cpus) { for_each_cpu(j, policy->cpus) {
struct cpufreq_policy *managed_policy;
struct device *cpu_dev; struct device *cpu_dev;
if (j == cpu) if (j == cpu)
continue; continue;
pr_debug("CPU %u already managed, adding link\n", j); pr_debug("Adding link for CPU: %u\n", j);
managed_policy = cpufreq_cpu_get(cpu); cpufreq_cpu_get(cpu);
cpu_dev = get_cpu_device(j); cpu_dev = get_cpu_device(j);
ret = sysfs_create_link(&cpu_dev->kobj, &policy->kobj, ret = sysfs_create_link(&cpu_dev->kobj, &policy->kobj,
"cpufreq"); "cpufreq");
if (ret) { if (ret) {
cpufreq_cpu_put(managed_policy); cpufreq_cpu_put(policy);
return ret; return ret;
} }
} }