xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] cx23885: Fix some smatch warnings

Browse Source 
Make sure that it won't go past the config buffers

	drivers/media/pci/cx23885/cx23885-dvb.c:1733 dvb_register() warn: buffer overflow 'netup_xc5000_config' 2 <= s32max
	drivers/media/pci/cx23885/cx23885-dvb.c:1745 dvb_register() warn: buffer overflow 'netup_stv0367_config' 2 <= s32max
	drivers/media/pci/cx23885/cx23885-dvb.c:1752 dvb_register() warn: buffer overflow 'netup_xc5000_config' 2 <= s32max

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Mauro Carvalho Chehab
2016-09-22 13:37:06 -03:00
parent e3ea5e9448
commit e837d85c61
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/pci/cx23885/cx23885-dvb.c
View File

@@ -1720,6 +1720,9 @@ static int dvb_register(struct cx23885_tsport *port)
} }
break; break;
case CX23885_BOARD_NETUP_DUAL_DVB_T_C_CI_RF: case CX23885_BOARD_NETUP_DUAL_DVB_T_C_CI_RF:
if (port->nr > 2)
return 0;
i2c_bus = &dev->i2c_bus[0]; i2c_bus = &dev->i2c_bus[0];
mfe_shared = 1;/* MFE */ mfe_shared = 1;/* MFE */
port->frontends.gate = 0;/* not clear for me yet */ port->frontends.gate = 0;/* not clear for me yet */

2
drivers/media/pci/cx23885/cx23885.h
View File

@@ -257,7 +257,7 @@ struct cx23885_dmaqueue {
struct cx23885_tsport { struct cx23885_tsport {
struct cx23885_dev *dev; struct cx23885_dev *dev;
int nr; unsigned nr;
int sram_chno; int sram_chno;
struct vb2_dvb_frontends frontends; struct vb2_dvb_frontends frontends;