dm: do not override error code returned from dm_get_device()
Some of the device mapper targets override the error code returned by dm_get_device() and return either -EINVAL or -ENXIO. There is nothing gained by this override. It is better to propagate the returned error code unchanged to caller. This work was motivated by hitting an issue where the underlying device was busy but -EINVAL was being returned. After this change we get -EBUSY instead and it is easier to figure out the problem. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:

zatwierdzone przez
Mike Snitzer

rodzic
ab37844d61
commit
e80d1c805a
@@ -75,13 +75,15 @@ static int get_stripe(struct dm_target *ti, struct stripe_c *sc,
|
||||
{
|
||||
unsigned long long start;
|
||||
char dummy;
|
||||
int ret;
|
||||
|
||||
if (sscanf(argv[1], "%llu%c", &start, &dummy) != 1)
|
||||
return -EINVAL;
|
||||
|
||||
if (dm_get_device(ti, argv[0], dm_table_get_mode(ti->table),
|
||||
&sc->stripe[stripe].dev))
|
||||
return -ENXIO;
|
||||
ret = dm_get_device(ti, argv[0], dm_table_get_mode(ti->table),
|
||||
&sc->stripe[stripe].dev);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
sc->stripe[stripe].physical_start = start;
|
||||
|
||||
|
Reference in New Issue
Block a user