platform/chrome: wilco_ec: Add debugfs test_event file
This change introduces a new debugfs file 'test_event' that when written to causes the EC to generate a test event. This adds a second sub cmd for the test event, and pulls out send_ec_cmd to be a common helper between h1_gpio_get and test_event_set. Signed-off-by: Daniel Campello <campello@chromium.org> Reviewed-by: Benson Leung <bleung@chromium.org> Reviewed-by: Nick Crews <ncrews@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
This commit is contained in:

committed by
Enric Balletbo i Serra

parent
54ecb8f702
commit
e6679fd1e2
@@ -160,29 +160,29 @@ static const struct file_operations fops_raw = {
|
|||||||
|
|
||||||
#define CMD_KB_CHROME 0x88
|
#define CMD_KB_CHROME 0x88
|
||||||
#define SUB_CMD_H1_GPIO 0x0A
|
#define SUB_CMD_H1_GPIO 0x0A
|
||||||
|
#define SUB_CMD_TEST_EVENT 0x0B
|
||||||
|
|
||||||
struct h1_gpio_status_request {
|
struct ec_request {
|
||||||
u8 cmd; /* Always CMD_KB_CHROME */
|
u8 cmd; /* Always CMD_KB_CHROME */
|
||||||
u8 reserved;
|
u8 reserved;
|
||||||
u8 sub_cmd; /* Always SUB_CMD_H1_GPIO */
|
u8 sub_cmd;
|
||||||
} __packed;
|
} __packed;
|
||||||
|
|
||||||
struct hi_gpio_status_response {
|
struct ec_response {
|
||||||
u8 status; /* 0 if allowed */
|
u8 status; /* 0 if allowed */
|
||||||
u8 val; /* BIT(0)=ENTRY_TO_FACT_MODE, BIT(1)=SPI_CHROME_SEL */
|
u8 val;
|
||||||
} __packed;
|
} __packed;
|
||||||
|
|
||||||
static int h1_gpio_get(void *arg, u64 *val)
|
static int send_ec_cmd(struct wilco_ec_device *ec, u8 sub_cmd, u8 *out_val)
|
||||||
{
|
{
|
||||||
struct wilco_ec_device *ec = arg;
|
struct ec_request rq;
|
||||||
struct h1_gpio_status_request rq;
|
struct ec_response rs;
|
||||||
struct hi_gpio_status_response rs;
|
|
||||||
struct wilco_ec_message msg;
|
struct wilco_ec_message msg;
|
||||||
int ret;
|
int ret;
|
||||||
|
|
||||||
memset(&rq, 0, sizeof(rq));
|
memset(&rq, 0, sizeof(rq));
|
||||||
rq.cmd = CMD_KB_CHROME;
|
rq.cmd = CMD_KB_CHROME;
|
||||||
rq.sub_cmd = SUB_CMD_H1_GPIO;
|
rq.sub_cmd = sub_cmd;
|
||||||
|
|
||||||
memset(&msg, 0, sizeof(msg));
|
memset(&msg, 0, sizeof(msg));
|
||||||
msg.type = WILCO_EC_MSG_LEGACY;
|
msg.type = WILCO_EC_MSG_LEGACY;
|
||||||
@@ -196,13 +196,38 @@ static int h1_gpio_get(void *arg, u64 *val)
|
|||||||
if (rs.status)
|
if (rs.status)
|
||||||
return -EIO;
|
return -EIO;
|
||||||
|
|
||||||
*val = rs.val;
|
*out_val = rs.val;
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* h1_gpio_get() - Gets h1 gpio status.
|
||||||
|
* @arg: The wilco EC device.
|
||||||
|
* @val: BIT(0)=ENTRY_TO_FACT_MODE, BIT(1)=SPI_CHROME_SEL
|
||||||
|
*/
|
||||||
|
static int h1_gpio_get(void *arg, u64 *val)
|
||||||
|
{
|
||||||
|
return send_ec_cmd(arg, SUB_CMD_H1_GPIO, (u8 *)val);
|
||||||
|
}
|
||||||
|
|
||||||
DEFINE_DEBUGFS_ATTRIBUTE(fops_h1_gpio, h1_gpio_get, NULL, "0x%02llx\n");
|
DEFINE_DEBUGFS_ATTRIBUTE(fops_h1_gpio, h1_gpio_get, NULL, "0x%02llx\n");
|
||||||
|
|
||||||
|
/**
|
||||||
|
* test_event_set() - Sends command to EC to cause an EC test event.
|
||||||
|
* @arg: The wilco EC device.
|
||||||
|
* @val: unused.
|
||||||
|
*/
|
||||||
|
static int test_event_set(void *arg, u64 val)
|
||||||
|
{
|
||||||
|
u8 ret;
|
||||||
|
|
||||||
|
return send_ec_cmd(arg, SUB_CMD_TEST_EVENT, &ret);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Format is unused since it is only required for get method which is NULL */
|
||||||
|
DEFINE_DEBUGFS_ATTRIBUTE(fops_test_event, NULL, test_event_set, "%llu\n");
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* wilco_ec_debugfs_probe() - Create the debugfs node
|
* wilco_ec_debugfs_probe() - Create the debugfs node
|
||||||
* @pdev: The platform device, probably created in core.c
|
* @pdev: The platform device, probably created in core.c
|
||||||
@@ -226,6 +251,8 @@ static int wilco_ec_debugfs_probe(struct platform_device *pdev)
|
|||||||
debugfs_create_file("raw", 0644, debug_info->dir, NULL, &fops_raw);
|
debugfs_create_file("raw", 0644, debug_info->dir, NULL, &fops_raw);
|
||||||
debugfs_create_file("h1_gpio", 0444, debug_info->dir, ec,
|
debugfs_create_file("h1_gpio", 0444, debug_info->dir, ec,
|
||||||
&fops_h1_gpio);
|
&fops_h1_gpio);
|
||||||
|
debugfs_create_file("test_event", 0200, debug_info->dir, ec,
|
||||||
|
&fops_test_event);
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user