perf tools: Use list_del_init() more thorougly
To allow for destructors to check if they're operating on a object still in a list, and to avoid going from use after free list entries into still valid, or even also other already removed from list entries. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://lkml.kernel.org/n/tip-deh17ub44atyox3j90e6rksu@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
@@ -408,7 +408,7 @@ void auxtrace_queues__free(struct auxtrace_queues *queues)
|
||||
|
||||
buffer = list_entry(queues->queue_array[i].head.next,
|
||||
struct auxtrace_buffer, list);
|
||||
list_del(&buffer->list);
|
||||
list_del_init(&buffer->list);
|
||||
auxtrace_buffer__free(buffer);
|
||||
}
|
||||
}
|
||||
@@ -612,7 +612,7 @@ void auxtrace_index__free(struct list_head *head)
|
||||
struct auxtrace_index *auxtrace_index, *n;
|
||||
|
||||
list_for_each_entry_safe(auxtrace_index, n, head, list) {
|
||||
list_del(&auxtrace_index->list);
|
||||
list_del_init(&auxtrace_index->list);
|
||||
free(auxtrace_index);
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user