Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
Steffen Klassert says: ==================== pull request (net-next): ipsec-next 2019-07-05 1) A lot of work to remove indirections from the xfrm code. From Florian Westphal. 2) Fix a WARN_ON with ipv6 that triggered because of a forgotten break statement. From Florian Westphal. 3) Remove xfrmi_init_net, it is not needed. From Li RongQing. Please pull or let me know if there are problems. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
@@ -793,9 +793,7 @@ static void __exit ah6_fini(void)
|
||||
if (xfrm6_protocol_deregister(&ah6_protocol, IPPROTO_AH) < 0)
|
||||
pr_info("%s: can't remove protocol\n", __func__);
|
||||
|
||||
if (xfrm_unregister_type(&ah6_type, AF_INET6) < 0)
|
||||
pr_info("%s: can't remove xfrm type\n", __func__);
|
||||
|
||||
xfrm_unregister_type(&ah6_type, AF_INET6);
|
||||
}
|
||||
|
||||
module_init(ah6_init);
|
||||
|
@@ -41,8 +41,6 @@ struct esp_skb_cb {
|
||||
|
||||
#define ESP_SKB_CB(__skb) ((struct esp_skb_cb *)&((__skb)->cb[0]))
|
||||
|
||||
static u32 esp6_get_mtu(struct xfrm_state *x, int mtu);
|
||||
|
||||
/*
|
||||
* Allocate an AEAD request structure with extra space for SG and IV.
|
||||
*
|
||||
@@ -447,7 +445,7 @@ static int esp6_output(struct xfrm_state *x, struct sk_buff *skb)
|
||||
struct xfrm_dst *dst = (struct xfrm_dst *)skb_dst(skb);
|
||||
u32 padto;
|
||||
|
||||
padto = min(x->tfcpad, esp6_get_mtu(x, dst->child_mtu_cached));
|
||||
padto = min(x->tfcpad, xfrm_state_mtu(x, dst->child_mtu_cached));
|
||||
if (skb->len < padto)
|
||||
esp.tfclen = padto - skb->len;
|
||||
}
|
||||
@@ -687,21 +685,6 @@ out:
|
||||
return ret;
|
||||
}
|
||||
|
||||
static u32 esp6_get_mtu(struct xfrm_state *x, int mtu)
|
||||
{
|
||||
struct crypto_aead *aead = x->data;
|
||||
u32 blksize = ALIGN(crypto_aead_blocksize(aead), 4);
|
||||
unsigned int net_adj;
|
||||
|
||||
if (x->props.mode != XFRM_MODE_TUNNEL)
|
||||
net_adj = sizeof(struct ipv6hdr);
|
||||
else
|
||||
net_adj = 0;
|
||||
|
||||
return ((mtu - x->props.header_len - crypto_aead_authsize(aead) -
|
||||
net_adj) & ~(blksize - 1)) + net_adj - 2;
|
||||
}
|
||||
|
||||
static int esp6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
|
||||
u8 type, u8 code, int offset, __be32 info)
|
||||
{
|
||||
@@ -919,7 +902,6 @@ static const struct xfrm_type esp6_type = {
|
||||
.flags = XFRM_TYPE_REPLAY_PROT,
|
||||
.init_state = esp6_init_state,
|
||||
.destructor = esp6_destroy,
|
||||
.get_mtu = esp6_get_mtu,
|
||||
.input = esp6_input,
|
||||
.output = esp6_output,
|
||||
.hdr_offset = xfrm6_find_1stfragopt,
|
||||
@@ -951,8 +933,7 @@ static void __exit esp6_fini(void)
|
||||
{
|
||||
if (xfrm6_protocol_deregister(&esp6_protocol, IPPROTO_ESP) < 0)
|
||||
pr_info("%s: can't remove protocol\n", __func__);
|
||||
if (xfrm_unregister_type(&esp6_type, AF_INET6) < 0)
|
||||
pr_info("%s: can't remove xfrm type\n", __func__);
|
||||
xfrm_unregister_type(&esp6_type, AF_INET6);
|
||||
}
|
||||
|
||||
module_init(esp6_init);
|
||||
|
@@ -336,9 +336,7 @@ static int __init esp6_offload_init(void)
|
||||
|
||||
static void __exit esp6_offload_exit(void)
|
||||
{
|
||||
if (xfrm_unregister_type_offload(&esp6_type_offload, AF_INET6) < 0)
|
||||
pr_info("%s: can't remove xfrm type offload\n", __func__);
|
||||
|
||||
xfrm_unregister_type_offload(&esp6_type_offload, AF_INET6);
|
||||
inet6_del_offload(&esp6_offload, IPPROTO_ESP);
|
||||
}
|
||||
|
||||
|
@@ -206,8 +206,7 @@ static void __exit ipcomp6_fini(void)
|
||||
{
|
||||
if (xfrm6_protocol_deregister(&ipcomp6_protocol, IPPROTO_COMP) < 0)
|
||||
pr_info("%s: can't remove protocol\n", __func__);
|
||||
if (xfrm_unregister_type(&ipcomp6_type, AF_INET6) < 0)
|
||||
pr_info("%s: can't remove xfrm type\n", __func__);
|
||||
xfrm_unregister_type(&ipcomp6_type, AF_INET6);
|
||||
}
|
||||
|
||||
module_init(ipcomp6_init);
|
||||
|
@@ -499,10 +499,8 @@ static void __exit mip6_fini(void)
|
||||
{
|
||||
if (rawv6_mh_filter_unregister(mip6_mh_filter) < 0)
|
||||
pr_info("%s: can't remove rawv6 mh filter\n", __func__);
|
||||
if (xfrm_unregister_type(&mip6_rthdr_type, AF_INET6) < 0)
|
||||
pr_info("%s: can't remove xfrm type(rthdr)\n", __func__);
|
||||
if (xfrm_unregister_type(&mip6_destopt_type, AF_INET6) < 0)
|
||||
pr_info("%s: can't remove xfrm type(destopt)\n", __func__);
|
||||
xfrm_unregister_type(&mip6_rthdr_type, AF_INET6);
|
||||
xfrm_unregister_type(&mip6_destopt_type, AF_INET6);
|
||||
}
|
||||
|
||||
module_init(mip6_init);
|
||||
|
@@ -21,137 +21,6 @@
|
||||
#include <net/ipv6.h>
|
||||
#include <net/addrconf.h>
|
||||
|
||||
static void
|
||||
__xfrm6_init_tempsel(struct xfrm_selector *sel, const struct flowi *fl)
|
||||
{
|
||||
const struct flowi6 *fl6 = &fl->u.ip6;
|
||||
|
||||
/* Initialize temporary selector matching only
|
||||
* to current session. */
|
||||
*(struct in6_addr *)&sel->daddr = fl6->daddr;
|
||||
*(struct in6_addr *)&sel->saddr = fl6->saddr;
|
||||
sel->dport = xfrm_flowi_dport(fl, &fl6->uli);
|
||||
sel->dport_mask = htons(0xffff);
|
||||
sel->sport = xfrm_flowi_sport(fl, &fl6->uli);
|
||||
sel->sport_mask = htons(0xffff);
|
||||
sel->family = AF_INET6;
|
||||
sel->prefixlen_d = 128;
|
||||
sel->prefixlen_s = 128;
|
||||
sel->proto = fl6->flowi6_proto;
|
||||
sel->ifindex = fl6->flowi6_oif;
|
||||
}
|
||||
|
||||
static void
|
||||
xfrm6_init_temprop(struct xfrm_state *x, const struct xfrm_tmpl *tmpl,
|
||||
const xfrm_address_t *daddr, const xfrm_address_t *saddr)
|
||||
{
|
||||
x->id = tmpl->id;
|
||||
if (ipv6_addr_any((struct in6_addr *)&x->id.daddr))
|
||||
memcpy(&x->id.daddr, daddr, sizeof(x->sel.daddr));
|
||||
memcpy(&x->props.saddr, &tmpl->saddr, sizeof(x->props.saddr));
|
||||
if (ipv6_addr_any((struct in6_addr *)&x->props.saddr))
|
||||
memcpy(&x->props.saddr, saddr, sizeof(x->props.saddr));
|
||||
x->props.mode = tmpl->mode;
|
||||
x->props.reqid = tmpl->reqid;
|
||||
x->props.family = AF_INET6;
|
||||
}
|
||||
|
||||
/* distribution counting sort function for xfrm_state and xfrm_tmpl */
|
||||
static int
|
||||
__xfrm6_sort(void **dst, void **src, int n, int (*cmp)(void *p), int maxclass)
|
||||
{
|
||||
int count[XFRM_MAX_DEPTH] = { };
|
||||
int class[XFRM_MAX_DEPTH];
|
||||
int i;
|
||||
|
||||
for (i = 0; i < n; i++) {
|
||||
int c;
|
||||
class[i] = c = cmp(src[i]);
|
||||
count[c]++;
|
||||
}
|
||||
|
||||
for (i = 2; i < maxclass; i++)
|
||||
count[i] += count[i - 1];
|
||||
|
||||
for (i = 0; i < n; i++) {
|
||||
dst[count[class[i] - 1]++] = src[i];
|
||||
src[i] = NULL;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/*
|
||||
* Rule for xfrm_state:
|
||||
*
|
||||
* rule 1: select IPsec transport except AH
|
||||
* rule 2: select MIPv6 RO or inbound trigger
|
||||
* rule 3: select IPsec transport AH
|
||||
* rule 4: select IPsec tunnel
|
||||
* rule 5: others
|
||||
*/
|
||||
static int __xfrm6_state_sort_cmp(void *p)
|
||||
{
|
||||
struct xfrm_state *v = p;
|
||||
|
||||
switch (v->props.mode) {
|
||||
case XFRM_MODE_TRANSPORT:
|
||||
if (v->id.proto != IPPROTO_AH)
|
||||
return 1;
|
||||
else
|
||||
return 3;
|
||||
#if IS_ENABLED(CONFIG_IPV6_MIP6)
|
||||
case XFRM_MODE_ROUTEOPTIMIZATION:
|
||||
case XFRM_MODE_IN_TRIGGER:
|
||||
return 2;
|
||||
#endif
|
||||
case XFRM_MODE_TUNNEL:
|
||||
case XFRM_MODE_BEET:
|
||||
return 4;
|
||||
}
|
||||
return 5;
|
||||
}
|
||||
|
||||
static int
|
||||
__xfrm6_state_sort(struct xfrm_state **dst, struct xfrm_state **src, int n)
|
||||
{
|
||||
return __xfrm6_sort((void **)dst, (void **)src, n,
|
||||
__xfrm6_state_sort_cmp, 6);
|
||||
}
|
||||
|
||||
/*
|
||||
* Rule for xfrm_tmpl:
|
||||
*
|
||||
* rule 1: select IPsec transport
|
||||
* rule 2: select MIPv6 RO or inbound trigger
|
||||
* rule 3: select IPsec tunnel
|
||||
* rule 4: others
|
||||
*/
|
||||
static int __xfrm6_tmpl_sort_cmp(void *p)
|
||||
{
|
||||
struct xfrm_tmpl *v = p;
|
||||
switch (v->mode) {
|
||||
case XFRM_MODE_TRANSPORT:
|
||||
return 1;
|
||||
#if IS_ENABLED(CONFIG_IPV6_MIP6)
|
||||
case XFRM_MODE_ROUTEOPTIMIZATION:
|
||||
case XFRM_MODE_IN_TRIGGER:
|
||||
return 2;
|
||||
#endif
|
||||
case XFRM_MODE_TUNNEL:
|
||||
case XFRM_MODE_BEET:
|
||||
return 3;
|
||||
}
|
||||
return 4;
|
||||
}
|
||||
|
||||
static int
|
||||
__xfrm6_tmpl_sort(struct xfrm_tmpl **dst, struct xfrm_tmpl **src, int n)
|
||||
{
|
||||
return __xfrm6_sort((void **)dst, (void **)src, n,
|
||||
__xfrm6_tmpl_sort_cmp, 5);
|
||||
}
|
||||
|
||||
int xfrm6_extract_header(struct sk_buff *skb)
|
||||
{
|
||||
struct ipv6hdr *iph = ipv6_hdr(skb);
|
||||
@@ -171,12 +40,6 @@ int xfrm6_extract_header(struct sk_buff *skb)
|
||||
static struct xfrm_state_afinfo xfrm6_state_afinfo = {
|
||||
.family = AF_INET6,
|
||||
.proto = IPPROTO_IPV6,
|
||||
.eth_proto = htons(ETH_P_IPV6),
|
||||
.owner = THIS_MODULE,
|
||||
.init_tempsel = __xfrm6_init_tempsel,
|
||||
.init_temprop = xfrm6_init_temprop,
|
||||
.tmpl_sort = __xfrm6_tmpl_sort,
|
||||
.state_sort = __xfrm6_state_sort,
|
||||
.output = xfrm6_output,
|
||||
.output_finish = xfrm6_output_finish,
|
||||
.extract_input = xfrm6_extract_input,
|
||||
|
Reference in New Issue
Block a user