[SPARC64]: Fix of_iounmap() region release.
We need to pass in the resource otherwise we cannot release the region properly. We must know whether it is an I/O or MEM resource. Spotted by Eric Brower. Signed-off-by: David S. Miller <davem@davemloft.net>
Šī revīzija ir iekļauta:
@@ -1480,13 +1480,13 @@ static int __devinit su_probe(struct of_device *op, const struct of_device_id *m
|
||||
return 0;
|
||||
|
||||
out_unmap:
|
||||
of_iounmap(up->port.membase, up->reg_size);
|
||||
of_iounmap(&op->resource[0], up->port.membase, up->reg_size);
|
||||
return err;
|
||||
}
|
||||
|
||||
static int __devexit su_remove(struct of_device *dev)
|
||||
static int __devexit su_remove(struct of_device *op)
|
||||
{
|
||||
struct uart_sunsu_port *up = dev_get_drvdata(&dev->dev);;
|
||||
struct uart_sunsu_port *up = dev_get_drvdata(&op->dev);
|
||||
|
||||
if (up->su_type == SU_PORT_MS ||
|
||||
up->su_type == SU_PORT_KBD) {
|
||||
@@ -1499,9 +1499,9 @@ static int __devexit su_remove(struct of_device *dev)
|
||||
}
|
||||
|
||||
if (up->port.membase)
|
||||
of_iounmap(up->port.membase, up->reg_size);
|
||||
of_iounmap(&op->resource[0], up->port.membase, up->reg_size);
|
||||
|
||||
dev_set_drvdata(&dev->dev, NULL);
|
||||
dev_set_drvdata(&op->dev, NULL);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
Atsaukties uz šo jaunā problēmā
Block a user