net: fix race condition in several drivers when reading stats
Fix race condition in several network drivers when reading stats on 32bit UP architectures. These drivers update their stats in a BH context and therefore should use u64_stats_fetch_begin_bh/u64_stats_fetch_retry_bh instead of u64_stats_fetch_begin/u64_stats_fetch_retry when reading the stats. Signed-off-by: Kevin Groeneveld <kgroeneveld@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
此提交包含在:
@@ -127,9 +127,9 @@ static struct rtnl_link_stats64 *br_get_stats64(struct net_device *dev,
|
||||
const struct br_cpu_netstats *bstats
|
||||
= per_cpu_ptr(br->stats, cpu);
|
||||
do {
|
||||
start = u64_stats_fetch_begin(&bstats->syncp);
|
||||
start = u64_stats_fetch_begin_bh(&bstats->syncp);
|
||||
memcpy(&tmp, bstats, sizeof(tmp));
|
||||
} while (u64_stats_fetch_retry(&bstats->syncp, start));
|
||||
} while (u64_stats_fetch_retry_bh(&bstats->syncp, start));
|
||||
sum.tx_bytes += tmp.tx_bytes;
|
||||
sum.tx_packets += tmp.tx_packets;
|
||||
sum.rx_bytes += tmp.rx_bytes;
|
||||
|
新增問題並參考
封鎖使用者