瀏覽代碼

leaking_addresses: Always print a trailing newline

[ Upstream commit cf2a85efdade117e2169d6e26641016cbbf03ef0 ]

For files that lack trailing newlines and match a leaking address (e.g.
wchan[1]), the leaking_addresses.pl report would run together with the
next line, making things look corrupted.

Unconditionally remove the newline on input, and write it back out on
output.

[1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/

Signed-off-by: Kees Cook <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Sasha Levin <[email protected]>
Kees Cook 3 年之前
父節點
當前提交
e1d7f0202a
共有 1 個文件被更改,包括 2 次插入1 次删除
  1. 2 1
      scripts/leaking_addresses.pl

+ 2 - 1
scripts/leaking_addresses.pl

@@ -455,8 +455,9 @@ sub parse_file
 
 
 	open my $fh, "<", $file or return;
 	open my $fh, "<", $file or return;
 	while ( <$fh> ) {
 	while ( <$fh> ) {
+		chomp;
 		if (may_leak_address($_)) {
 		if (may_leak_address($_)) {
-			print $file . ': ' . $_;
+			printf("$file: $_\n");
 		}
 		}
 	}
 	}
 	close $fh;
 	close $fh;