crypto: qce - fix uaf on qce_ahash_register_one
[ Upstream commit b4cb4d31631912842eb7dce02b4350cbb7562d5e ]
Pointer base points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing base before free tmpl.
Fixes: ec8f5d8f
("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
5de640f59f
commit
e19b3c1b57
@@ -533,8 +533,8 @@ static int qce_ahash_register_one(const struct qce_ahash_def *def,
|
|||||||
|
|
||||||
ret = crypto_register_ahash(alg);
|
ret = crypto_register_ahash(alg);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
kfree(tmpl);
|
|
||||||
dev_err(qce->dev, "%s registration failed\n", base->cra_name);
|
dev_err(qce->dev, "%s registration failed\n", base->cra_name);
|
||||||
|
kfree(tmpl);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user