net: convert print_mac to %pM
This converts pretty much everything to print_mac. There were a few things that had conflicts which I have just dropped for now, no harm done. I've built an allyesconfig with this and looked at the files that weren't built very carefully, but it's a huge patch. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
0c68ae2605
commit
e174961ca1
@@ -99,7 +99,6 @@ static int __devinit abyss_attach(struct pci_dev *pdev, const struct pci_device_
|
||||
struct net_local *tp;
|
||||
int ret, pci_irq_line;
|
||||
unsigned long pci_ioaddr;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
if (versionprinted++ == 0)
|
||||
printk("%s", version);
|
||||
@@ -147,8 +146,7 @@ static int __devinit abyss_attach(struct pci_dev *pdev, const struct pci_device_
|
||||
|
||||
abyss_read_eeprom(dev);
|
||||
|
||||
printk("%s: Ring Station Address: %s\n",
|
||||
dev->name, print_mac(mac, dev->dev_addr));
|
||||
printk("%s: Ring Station Address: %pM\n", dev->name, dev->dev_addr);
|
||||
|
||||
tp = netdev_priv(dev);
|
||||
tp->setnselout = abyss_setnselout_pins;
|
||||
|
@@ -389,7 +389,6 @@ static int __devinit ibmtr_probe1(struct net_device *dev, int PIOaddr)
|
||||
unsigned long timeout;
|
||||
static int version_printed;
|
||||
#endif
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
/* Query the adapter PIO base port which will return
|
||||
* indication of where MMIO was placed. We also have a
|
||||
@@ -703,8 +702,7 @@ static int __devinit ibmtr_probe1(struct net_device *dev, int PIOaddr)
|
||||
channel_def[cardpresent - 1], adapter_def(ti->adapter_type));
|
||||
DPRINTK("using irq %d, PIOaddr %hx, %dK shared RAM.\n",
|
||||
irq, PIOaddr, ti->mapped_ram_size / 2);
|
||||
DPRINTK("Hardware address : %s\n",
|
||||
print_mac(mac, dev->dev_addr));
|
||||
DPRINTK("Hardware address : %pM\n", dev->dev_addr);
|
||||
if (ti->page_mask)
|
||||
DPRINTK("Shared RAM paging enabled. "
|
||||
"Page size: %uK Shared Ram size %dK\n",
|
||||
@@ -1741,8 +1739,6 @@ static void tr_rx(struct net_device *dev)
|
||||
void __iomem *trhhdr = rbuf + offsetof(struct rec_buf, data);
|
||||
u8 saddr[6];
|
||||
u8 daddr[6];
|
||||
DECLARE_MAC_BUF(mac);
|
||||
DECLARE_MAC_BUF(mac2);
|
||||
int i;
|
||||
for (i = 0 ; i < 6 ; i++)
|
||||
saddr[i] = readb(trhhdr + SADDR_OFST + i);
|
||||
@@ -1750,9 +1746,9 @@ static void tr_rx(struct net_device *dev)
|
||||
daddr[i] = readb(trhhdr + DADDR_OFST + i);
|
||||
DPRINTK("Probably non-IP frame received.\n");
|
||||
DPRINTK("ssap: %02X dsap: %02X "
|
||||
"saddr: %s daddr: %$s\n",
|
||||
"saddr: %pM daddr: %pM\n",
|
||||
readb(llc + SSAP_OFST), readb(llc + DSAP_OFST),
|
||||
print_mac(mac, saddr), print_mac(mac2, daddr));
|
||||
saddr, daddr);
|
||||
}
|
||||
#endif
|
||||
|
||||
|
@@ -446,9 +446,6 @@ static int streamer_reset(struct net_device *dev)
|
||||
unsigned int uaa_addr;
|
||||
struct sk_buff *skb = NULL;
|
||||
__u16 misr;
|
||||
#if STREAMER_DEBUG
|
||||
DECLARE_MAC_BUF(mac);
|
||||
#endif
|
||||
|
||||
streamer_priv = netdev_priv(dev);
|
||||
streamer_mmio = streamer_priv->streamer_mmio;
|
||||
@@ -577,8 +574,7 @@ static int streamer_reset(struct net_device *dev)
|
||||
dev->dev_addr[i+1]= addr & 0xff;
|
||||
}
|
||||
#if STREAMER_DEBUG
|
||||
printk("Adapter address: %s\n",
|
||||
print_mac(mac, dev->dev_addr));
|
||||
printk("Adapter address: %pM\n", dev->dev_addr);
|
||||
#endif
|
||||
}
|
||||
return 0;
|
||||
@@ -1538,7 +1534,6 @@ static void streamer_arb_cmd(struct net_device *dev)
|
||||
|
||||
#if STREAMER_NETWORK_MONITOR
|
||||
struct trh_hdr *mac_hdr;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
#endif
|
||||
|
||||
writew(streamer_priv->arb, streamer_mmio + LAPA);
|
||||
@@ -1611,11 +1606,11 @@ static void streamer_arb_cmd(struct net_device *dev)
|
||||
dev->name);
|
||||
mac_hdr = tr_hdr(mac_frame);
|
||||
printk(KERN_WARNING
|
||||
"%s: MAC Frame Dest. Addr: %s\n",
|
||||
dev->name, print_mac(mac, mac_hdr->daddr));
|
||||
"%s: MAC Frame Dest. Addr: %pM\n",
|
||||
dev->name, mac_hdr->daddr);
|
||||
printk(KERN_WARNING
|
||||
"%s: MAC Frame Srce. Addr: %s\n",
|
||||
dev->name, DEV->ADDR6(mac_hdr->saddr));
|
||||
"%s: MAC Frame Srce. Addr: %pM\n",
|
||||
dev->name, mac_hdr->saddr);
|
||||
#endif
|
||||
netif_rx(mac_frame);
|
||||
|
||||
@@ -1850,8 +1845,6 @@ static int sprintf_info(char *buffer, struct net_device *dev)
|
||||
struct streamer_parameters_table spt;
|
||||
int size = 0;
|
||||
int i;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
DECLARE_MAC_BUF(mac2);
|
||||
|
||||
writew(streamer_priv->streamer_addr_table_addr, streamer_mmio + LAPA);
|
||||
for (i = 0; i < 14; i += 2) {
|
||||
@@ -1873,9 +1866,8 @@ static int sprintf_info(char *buffer, struct net_device *dev)
|
||||
size = sprintf(buffer, "\n%6s: Adapter Address : Node Address : Functional Addr\n", dev->name);
|
||||
|
||||
size += sprintf(buffer + size,
|
||||
"%6s: %s : %s : %02x:%02x:%02x:%02x\n",
|
||||
dev->name, print_mac(mac, dev->dev_addr),
|
||||
print_mac(mac2, sat.node_addr),
|
||||
"%6s: %pM : %pM : %02x:%02x:%02x:%02x\n",
|
||||
dev->name, dev->dev_addr, sat.node_addr,
|
||||
sat.func_addr[0], sat.func_addr[1],
|
||||
sat.func_addr[2], sat.func_addr[3]);
|
||||
|
||||
@@ -1884,19 +1876,18 @@ static int sprintf_info(char *buffer, struct net_device *dev)
|
||||
size += sprintf(buffer + size, "%6s: Physical Addr : Up Node Address : Poll Address : AccPri : Auth Src : Att Code :\n", dev->name);
|
||||
|
||||
size += sprintf(buffer + size,
|
||||
"%6s: %02x:%02x:%02x:%02x : %s : %s : %04x : %04x : %04x :\n",
|
||||
"%6s: %02x:%02x:%02x:%02x : %pM : %pM : %04x : %04x : %04x :\n",
|
||||
dev->name, spt.phys_addr[0], spt.phys_addr[1],
|
||||
spt.phys_addr[2], spt.phys_addr[3],
|
||||
print_mac(mac, spt.up_node_addr),
|
||||
print_mac(mac2, spt.poll_addr),
|
||||
spt.up_node_addr, spt.poll_addr,
|
||||
ntohs(spt.acc_priority), ntohs(spt.auth_source_class),
|
||||
ntohs(spt.att_code));
|
||||
|
||||
size += sprintf(buffer + size, "%6s: Source Address : Bcn T : Maj. V : Lan St : Lcl Rg : Mon Err : Frame Correl : \n", dev->name);
|
||||
|
||||
size += sprintf(buffer + size,
|
||||
"%6s: %s : %04x : %04x : %04x : %04x : %04x : %04x : \n",
|
||||
dev->name, print_mac(mac, spt.source_addr),
|
||||
"%6s: %pM : %04x : %04x : %04x : %04x : %04x : %04x : \n",
|
||||
dev->name, spt.source_addr,
|
||||
ntohs(spt.beacon_type), ntohs(spt.major_vector),
|
||||
ntohs(spt.lan_status), ntohs(spt.local_ring),
|
||||
ntohs(spt.mon_error), ntohs(spt.frame_correl));
|
||||
@@ -1905,10 +1896,10 @@ static int sprintf_info(char *buffer, struct net_device *dev)
|
||||
dev->name);
|
||||
|
||||
size += sprintf(buffer + size,
|
||||
"%6s: : %02x : %02x : %s : %02x:%02x:%02x:%02x : \n",
|
||||
"%6s: : %02x : %02x : %pM : %02x:%02x:%02x:%02x : \n",
|
||||
dev->name, ntohs(spt.beacon_transmit),
|
||||
ntohs(spt.beacon_receive),
|
||||
print_mac(mac, spt.beacon_naun),
|
||||
spt.beacon_naun,
|
||||
spt.beacon_phys[0], spt.beacon_phys[1],
|
||||
spt.beacon_phys[2], spt.beacon_phys[3]);
|
||||
return size;
|
||||
|
@@ -152,7 +152,6 @@ static int __devinit madgemc_probe(struct device *device)
|
||||
struct card_info *card;
|
||||
struct mca_device *mdev = to_mca_device(device);
|
||||
int ret = 0;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
if (versionprinted++ == 0)
|
||||
printk("%s", version);
|
||||
@@ -323,8 +322,8 @@ static int __devinit madgemc_probe(struct device *device)
|
||||
mca_device_set_name(mdev, (card->cardtype == 0x08)?MADGEMC16_CARDNAME:MADGEMC32_CARDNAME);
|
||||
mca_set_adapter_procfn(mdev->slot, madgemc_mcaproc, dev);
|
||||
|
||||
printk("%s: Ring Station Address: %s\n",
|
||||
dev->name, print_mac(mac, dev->dev_addr));
|
||||
printk("%s: Ring Station Address: %pM\n",
|
||||
dev->name, dev->dev_addr);
|
||||
|
||||
if (tmsdev_init(dev, device)) {
|
||||
printk("%s: unable to get memory for dev->priv.\n",
|
||||
@@ -690,7 +689,6 @@ static int madgemc_mcaproc(char *buf, int slot, void *d)
|
||||
struct net_local *tp = netdev_priv(dev);
|
||||
struct card_info *curcard = tp->tmspriv;
|
||||
int len = 0;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
len += sprintf(buf+len, "-------\n");
|
||||
if (curcard) {
|
||||
@@ -714,8 +712,8 @@ static int madgemc_mcaproc(char *buf, int slot, void *d)
|
||||
}
|
||||
len += sprintf(buf+len, " (%s)\n", (curcard->fairness)?"Unfair":"Fair");
|
||||
|
||||
len += sprintf(buf+len, "Ring Station Address: %s\n",
|
||||
print_mac(mac, dev->dev_addr));
|
||||
len += sprintf(buf+len, "Ring Station Address: %pM\n",
|
||||
dev->dev_addr);
|
||||
} else
|
||||
len += sprintf(buf+len, "Card not configured\n");
|
||||
|
||||
|
@@ -421,10 +421,7 @@ static int olympic_init(struct net_device *dev)
|
||||
memcpy_fromio(&dev->dev_addr[0], adapter_addr,6);
|
||||
|
||||
#if OLYMPIC_DEBUG
|
||||
{
|
||||
DECLARE_MAC_BUF(mac);
|
||||
printk("adapter address: %s\n", print_mac(mac, dev->dev_addr));
|
||||
}
|
||||
printk("adapter address: %pM\n", dev->dev_addr);
|
||||
#endif
|
||||
|
||||
olympic_priv->olympic_addr_table_addr = swab16(readw(init_srb + 12));
|
||||
@@ -441,7 +438,6 @@ static int olympic_open(struct net_device *dev)
|
||||
unsigned long flags, t;
|
||||
int i, open_finished = 1 ;
|
||||
u8 resp, err;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
DECLARE_WAITQUEUE(wait,current) ;
|
||||
|
||||
@@ -569,8 +565,8 @@ static int olympic_open(struct net_device *dev)
|
||||
goto out;
|
||||
|
||||
case 0x32:
|
||||
printk(KERN_WARNING "%s: Invalid LAA: %s\n",
|
||||
dev->name, print_mac(mac, olympic_priv->olympic_laa));
|
||||
printk(KERN_WARNING "%s: Invalid LAA: %pM\n",
|
||||
dev->name, olympic_priv->olympic_laa);
|
||||
goto out;
|
||||
|
||||
default:
|
||||
@@ -704,13 +700,12 @@ static int olympic_open(struct net_device *dev)
|
||||
u8 __iomem *opt;
|
||||
int i;
|
||||
u8 addr[6];
|
||||
DECLARE_MAC_BUF(mac);
|
||||
oat = (olympic_priv->olympic_lap + olympic_priv->olympic_addr_table_addr);
|
||||
opt = (olympic_priv->olympic_lap + olympic_priv->olympic_parms_addr);
|
||||
|
||||
for (i = 0; i < 6; i++)
|
||||
addr[i] = readb(oat+offsetof(struct olympic_adapter_addr_table,node_addr)+i);
|
||||
printk("%s: Node Address: %s\n",dev->name, print_mac(mac, addr));
|
||||
printk("%s: Node Address: %pM\n", dev->name, addr);
|
||||
printk("%s: Functional Address: %02x:%02x:%02x:%02x\n",dev->name,
|
||||
readb(oat+offsetof(struct olympic_adapter_addr_table,func_addr)),
|
||||
readb(oat+offsetof(struct olympic_adapter_addr_table,func_addr)+1),
|
||||
@@ -719,7 +714,7 @@ static int olympic_open(struct net_device *dev)
|
||||
|
||||
for (i = 0; i < 6; i++)
|
||||
addr[i] = readb(opt+offsetof(struct olympic_parameters_table, up_node_addr)+i);
|
||||
printk("%s: NAUN Address: %s\n",dev->name, print_mac(mac, addr));
|
||||
printk("%s: NAUN Address: %pM\n", dev->name, addr);
|
||||
}
|
||||
|
||||
netif_start_queue(dev);
|
||||
@@ -1440,16 +1435,10 @@ static void olympic_arb_cmd(struct net_device *dev)
|
||||
struct trh_hdr *mac_hdr;
|
||||
printk(KERN_WARNING "%s: Received MAC Frame, details: \n",dev->name);
|
||||
mac_hdr = tr_hdr(mac_frame);
|
||||
printk(KERN_WARNING "%s: MAC Frame Dest. Addr: "
|
||||
MAC_FMT " \n", dev->name,
|
||||
mac_hdr->daddr[0], mac_hdr->daddr[1],
|
||||
mac_hdr->daddr[2], mac_hdr->daddr[3],
|
||||
mac_hdr->daddr[4], mac_hdr->daddr[5]);
|
||||
printk(KERN_WARNING "%s: MAC Frame Srce. Addr: "
|
||||
MAC_FMT " \n", dev->name,
|
||||
mac_hdr->saddr[0], mac_hdr->saddr[1],
|
||||
mac_hdr->saddr[2], mac_hdr->saddr[3],
|
||||
mac_hdr->saddr[4], mac_hdr->saddr[5]);
|
||||
printk(KERN_WARNING "%s: MAC Frame Dest. Addr: %pM\n",
|
||||
dev->name, mac_hdr->daddr);
|
||||
printk(KERN_WARNING "%s: MAC Frame Srce. Addr: %pM\n",
|
||||
dev->name, mac_hdr->saddr);
|
||||
}
|
||||
netif_rx(mac_frame);
|
||||
dev->last_rx = jiffies;
|
||||
@@ -1647,8 +1636,6 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
|
||||
u8 addr[6];
|
||||
u8 addr2[6];
|
||||
int i;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
DECLARE_MAC_BUF(mac2);
|
||||
|
||||
size = sprintf(buffer,
|
||||
"IBM Pit/Pit-Phy/Olympic Chipset Token Ring Adapter %s\n",dev->name);
|
||||
@@ -1658,10 +1645,9 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
|
||||
for (i = 0 ; i < 6 ; i++)
|
||||
addr[i] = readb(oat+offsetof(struct olympic_adapter_addr_table,node_addr) + i);
|
||||
|
||||
size += sprintf(buffer+size, "%6s: %s : %s : %02x:%02x:%02x:%02x\n",
|
||||
size += sprintf(buffer+size, "%6s: %pM : %pM : %02x:%02x:%02x:%02x\n",
|
||||
dev->name,
|
||||
print_mac(mac, dev->dev_addr),
|
||||
print_mac(mac2, addr),
|
||||
dev->dev_addr, addr,
|
||||
readb(oat+offsetof(struct olympic_adapter_addr_table,func_addr)),
|
||||
readb(oat+offsetof(struct olympic_adapter_addr_table,func_addr)+1),
|
||||
readb(oat+offsetof(struct olympic_adapter_addr_table,func_addr)+2),
|
||||
@@ -1677,14 +1663,13 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
|
||||
for (i = 0 ; i < 6 ; i++)
|
||||
addr2[i] = readb(opt+offsetof(struct olympic_parameters_table, poll_addr) + i);
|
||||
|
||||
size += sprintf(buffer+size, "%6s: %02x:%02x:%02x:%02x : %s : %s : %04x : %04x : %04x :\n",
|
||||
size += sprintf(buffer+size, "%6s: %02x:%02x:%02x:%02x : %pM : %pM : %04x : %04x : %04x :\n",
|
||||
dev->name,
|
||||
readb(opt+offsetof(struct olympic_parameters_table, phys_addr)),
|
||||
readb(opt+offsetof(struct olympic_parameters_table, phys_addr)+1),
|
||||
readb(opt+offsetof(struct olympic_parameters_table, phys_addr)+2),
|
||||
readb(opt+offsetof(struct olympic_parameters_table, phys_addr)+3),
|
||||
print_mac(mac, addr),
|
||||
print_mac(mac2, addr2),
|
||||
addr, addr2,
|
||||
swab16(readw(opt+offsetof(struct olympic_parameters_table, acc_priority))),
|
||||
swab16(readw(opt+offsetof(struct olympic_parameters_table, auth_source_class))),
|
||||
swab16(readw(opt+offsetof(struct olympic_parameters_table, att_code))));
|
||||
@@ -1694,9 +1679,8 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
|
||||
|
||||
for (i = 0 ; i < 6 ; i++)
|
||||
addr[i] = readb(opt+offsetof(struct olympic_parameters_table, source_addr) + i);
|
||||
size += sprintf(buffer+size, "%6s: %s : %04x : %04x : %04x : %04x : %04x : %04x : \n",
|
||||
dev->name,
|
||||
print_mac(mac, addr),
|
||||
size += sprintf(buffer+size, "%6s: %pM : %04x : %04x : %04x : %04x : %04x : %04x : \n",
|
||||
dev->name, addr,
|
||||
swab16(readw(opt+offsetof(struct olympic_parameters_table, beacon_type))),
|
||||
swab16(readw(opt+offsetof(struct olympic_parameters_table, major_vector))),
|
||||
swab16(readw(opt+offsetof(struct olympic_parameters_table, lan_status))),
|
||||
@@ -1709,11 +1693,11 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
|
||||
|
||||
for (i = 0 ; i < 6 ; i++)
|
||||
addr[i] = readb(opt+offsetof(struct olympic_parameters_table, beacon_naun) + i);
|
||||
size += sprintf(buffer+size, "%6s: : %02x : %02x : %s : %02x:%02x:%02x:%02x : \n",
|
||||
size += sprintf(buffer+size, "%6s: : %02x : %02x : %pM : %02x:%02x:%02x:%02x : \n",
|
||||
dev->name,
|
||||
swab16(readw(opt+offsetof(struct olympic_parameters_table, beacon_transmit))),
|
||||
swab16(readw(opt+offsetof(struct olympic_parameters_table, beacon_receive))),
|
||||
print_mac(mac, addr),
|
||||
addr,
|
||||
readb(opt+offsetof(struct olympic_parameters_table, beacon_phys)),
|
||||
readb(opt+offsetof(struct olympic_parameters_table, beacon_phys)+1),
|
||||
readb(opt+offsetof(struct olympic_parameters_table, beacon_phys)+2),
|
||||
|
@@ -122,7 +122,6 @@ static int __init setup_card(struct net_device *dev, struct device *pdev)
|
||||
static int versionprinted;
|
||||
const unsigned *port;
|
||||
int j,err = 0;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
if (!dev)
|
||||
return -ENOMEM;
|
||||
@@ -153,8 +152,8 @@ static int __init setup_card(struct net_device *dev, struct device *pdev)
|
||||
|
||||
proteon_read_eeprom(dev);
|
||||
|
||||
printk(KERN_DEBUG "proteon.c: Ring Station Address: %s\n",
|
||||
print_mac(mac, dev->dev_addr));
|
||||
printk(KERN_DEBUG "proteon.c: Ring Station Address: %pM\n",
|
||||
dev->dev_addr);
|
||||
|
||||
tp = netdev_priv(dev);
|
||||
tp->setnselout = proteon_setnselout_pins;
|
||||
|
@@ -139,7 +139,6 @@ static int __init setup_card(struct net_device *dev, struct device *pdev)
|
||||
static int versionprinted;
|
||||
const unsigned *port;
|
||||
int j, err = 0;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
if (!dev)
|
||||
return -ENOMEM;
|
||||
@@ -170,8 +169,8 @@ static int __init setup_card(struct net_device *dev, struct device *pdev)
|
||||
|
||||
sk_isa_read_eeprom(dev);
|
||||
|
||||
printk(KERN_DEBUG "skisa.c: Ring Station Address: %s\n",
|
||||
print_mac(mac, dev->dev_addr));
|
||||
printk(KERN_DEBUG "skisa.c: Ring Station Address: %pM\n",
|
||||
dev->dev_addr);
|
||||
|
||||
tp = netdev_priv(dev);
|
||||
tp->setnselout = sk_isa_setnselout_pins;
|
||||
|
@@ -100,7 +100,6 @@ static int __devinit tms_pci_attach(struct pci_dev *pdev, const struct pci_devic
|
||||
unsigned int pci_irq_line;
|
||||
unsigned long pci_ioaddr;
|
||||
struct card_info *cardinfo = &card_info_table[ent->driver_data];
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
if (versionprinted++ == 0)
|
||||
printk("%s", version);
|
||||
@@ -137,8 +136,8 @@ static int __devinit tms_pci_attach(struct pci_dev *pdev, const struct pci_devic
|
||||
|
||||
tms_pci_read_eeprom(dev);
|
||||
|
||||
printk("%s: Ring Station Address: %s\n",
|
||||
dev->name, print_mac(mac, dev->dev_addr));
|
||||
printk("%s: Ring Station Address: %pM\n",
|
||||
dev->name, dev->dev_addr);
|
||||
|
||||
ret = tmsdev_init(dev, &pdev->dev);
|
||||
if (ret) {
|
||||
|
Reference in New Issue
Block a user