xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

um: Fix ptrace GETREGS/SETREGS bugs

Browse Source 
This fix two related bugs:
* PTRACE_GETREGS doesn't get the right orig_ax (syscall) value
* PTRACE_SETREGS can't set the orig_ax value (erased by initial value)

Get rid of the now useless and error-prone get_syscall().

Fix inconsistent behavior in the ptrace implementation for i386 when
updating orig_eax automatically update the syscall number as well. This
is now updated in handle_syscall().

Signed-off-by: Mickaël Salaün <mic@digikod.net>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Kees Cook <keescook@chromium.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Will Drewry <wad@chromium.org>
Cc: Thomas Meyer <thomas@m3y3r.de>
Cc: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Anton Ivanov <aivanov@brocade.com>
Cc: Meredydd Luff <meredydd@senatehouse.org>
Cc: David Drysdale <drysdale@google.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
Mickaël Salaün
2015-12-29 21:35:44 +01:00
committed by Richard Weinberger
parent a7df4716d1
commit e04c989eb7
4 changed files with 17 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
arch/um/os-Linux/skas/process.c
View File

@@ -172,13 +172,6 @@ static void handle_trap(int pid, struct uml_pt_regs *regs,
handle_syscall(regs);
}
int get_syscall(struct uml_pt_regs *regs)
{
UPT_SYSCALL_NR(regs) = PT_SYSCALL_NR(regs->gp);
return UPT_SYSCALL_NR(regs);
}
extern char __syscall_stub_start[];
static int userspace_tramp(void *stack)