ovl: make private mounts longterm
Overlayfs is using clone_private_mount() to create internal mounts for underlying layers. These are used for operations requiring a path, such as dentry_open(). Since these private mounts are not in any namespace they are treated as short term, "detached" mounts and mntput() involves taking the global mount_lock, which can result in serious cacheline pingpong. Make these private mounts longterm instead, which trade the penalty on mntput() for a slightly longer shutdown time due to an added RCU grace period when putting these mounts. Introduce a new helper kern_unmount_many() that can take care of multiple longterm mounts with a single RCU grace period. Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
这个提交包含在:
@@ -211,6 +211,7 @@ static void ovl_destroy_inode(struct inode *inode)
|
||||
|
||||
static void ovl_free_fs(struct ovl_fs *ofs)
|
||||
{
|
||||
struct vfsmount **mounts;
|
||||
unsigned i;
|
||||
|
||||
iput(ofs->workbasedir_trap);
|
||||
@@ -224,10 +225,14 @@ static void ovl_free_fs(struct ovl_fs *ofs)
|
||||
dput(ofs->workbasedir);
|
||||
if (ofs->upperdir_locked)
|
||||
ovl_inuse_unlock(ovl_upper_mnt(ofs)->mnt_root);
|
||||
|
||||
/* Hack! Reuse ofs->layers as a vfsmount array before freeing it */
|
||||
mounts = (struct vfsmount **) ofs->layers;
|
||||
for (i = 0; i < ofs->numlayer; i++) {
|
||||
iput(ofs->layers[i].trap);
|
||||
mntput(ofs->layers[i].mnt);
|
||||
mounts[i] = ofs->layers[i].mnt;
|
||||
}
|
||||
kern_unmount_array(mounts, ofs->numlayer);
|
||||
kfree(ofs->layers);
|
||||
for (i = 0; i < ofs->numfs; i++)
|
||||
free_anon_bdev(ofs->fs[i].pseudo_dev);
|
||||
|
在新工单中引用
屏蔽一个用户