[TG3]: Add recovery logic when MMIOs are re-ordered
Add recovery logic when we suspect that the system is re-ordering MMIOs. Re-ordered MMIOs to the send mailbox can cause bogus tx completions and hit BUG_ON() in the tx completion path. tg3 already has logic to handle re-ordered MMIOs by flushing the MMIOs that must be strictly ordered (such as the send mailbox). Determining when to enable the flush is currently a manual process of adding known chipsets to a list. The new code replaces the BUG_ON() in the tx completion path with the call to tg3_tx_recover(). It will set the TG3_FLAG_MBOX_WRITE_REORDER flag and reset the chip later in the workqueue to recover and start flushing MMIOs to the mailbox. A message to report the problem will be printed. We will then decide whether or not to add the host bridge to the list of chipsets that do re-ordering. We may add some additional code later to print the host bridge's ID so that the user can report it more easily. The assumption that re-ordering can only happen on x86 systems is also removed. Signed-off-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
30b6c28d2a
commit
df3e654818
@@ -2155,11 +2155,7 @@ struct tg3 {
|
||||
#define TG3_FLAG_ENABLE_ASF 0x00000020
|
||||
#define TG3_FLAG_5701_REG_WRITE_BUG 0x00000040
|
||||
#define TG3_FLAG_POLL_SERDES 0x00000080
|
||||
#if defined(CONFIG_X86)
|
||||
#define TG3_FLAG_MBOX_WRITE_REORDER 0x00000100
|
||||
#else
|
||||
#define TG3_FLAG_MBOX_WRITE_REORDER 0 /* disables code too */
|
||||
#endif
|
||||
#define TG3_FLAG_PCIX_TARGET_HWBUG 0x00000200
|
||||
#define TG3_FLAG_WOL_SPEED_100MB 0x00000400
|
||||
#define TG3_FLAG_WOL_ENABLE 0x00000800
|
||||
@@ -2172,6 +2168,7 @@ struct tg3 {
|
||||
#define TG3_FLAG_PCI_HIGH_SPEED 0x00040000
|
||||
#define TG3_FLAG_PCI_32BIT 0x00080000
|
||||
#define TG3_FLAG_SRAM_USE_CONFIG 0x00100000
|
||||
#define TG3_FLAG_TX_RECOVERY_PENDING 0x00200000
|
||||
#define TG3_FLAG_SERDES_WOL_CAP 0x00400000
|
||||
#define TG3_FLAG_JUMBO_RING_ENABLE 0x00800000
|
||||
#define TG3_FLAG_10_100_ONLY 0x01000000
|
||||
|
Reference in New Issue
Block a user