xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: phy: fix return value check of usb_get_phy

Browse Source 
usb_get_phy will return -ENODEV if it's not able to find the phy. Hence
fixed all the callers of usb_get_phy to check for this error condition
instead of relying on a non-zero value as success condition.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Kishon Vijay Abraham I
2012-06-26 17:40:32 +05:30
committed by Felipe Balbi
parent b8a3efa3a3
commit ded017ee6c
25 changed files with 96 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/otg/otg.c
View File

@@ -67,7 +67,7 @@ struct usb_phy *devm_usb_get_phy(struct device *dev, enum usb_phy_type type)
return NULL;
phy = usb_get_phy(type);
if (phy) {
if (!IS_ERR(phy)) {
*ptr = phy;
devres_add(dev, ptr);
} else
@@ -82,7 +82,7 @@ EXPORT_SYMBOL(devm_usb_get_phy);
* @type - the type of the phy the controller requires
*
* Returns the phy driver, after getting a refcount to it; or
* null if there is no such phy. The caller is responsible for
* -ENODEV if there is no such phy. The caller is responsible for
* calling usb_put_phy() to release that count.
*
* For use by USB host and peripheral drivers.