coda: remove CODA_FS_OLD_API
While fixing CONFIG_ leakages to the userspace kernel headers I ran into CODA_FS_OLD_API. After five years, are there still people using the old API left? Especially considering that you have to choose at compile time which API to support in the kernel (and distributions tend to offer the new API for some time). Jan: "The old API can definitely go. Around the time the new interface went in there were some non-Coda userspace file system implementations that took a while longer to convert to the new API, but by now they all switched to the new interface or in some cases to a FUSE-based solution." Signed-off-by: Adrian Bunk <bunk@kernel.org> Acked-by: Jan Harkes <jaharkes@cs.cmu.edu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
c0a1633b62
commit
de0ca06a99
@@ -52,12 +52,8 @@ static void *alloc_upcall(int opcode, int size)
|
||||
inp->ih.opcode = opcode;
|
||||
inp->ih.pid = current->pid;
|
||||
inp->ih.pgid = task_pgrp_nr(current);
|
||||
#ifdef CONFIG_CODA_FS_OLD_API
|
||||
memset(&inp->ih.cred, 0, sizeof(struct coda_cred));
|
||||
inp->ih.cred.cr_fsuid = current->fsuid;
|
||||
#else
|
||||
inp->ih.uid = current->fsuid;
|
||||
#endif
|
||||
|
||||
return (void*)inp;
|
||||
}
|
||||
|
||||
@@ -166,20 +162,11 @@ int venus_close(struct super_block *sb, struct CodaFid *fid, int flags,
|
||||
union inputArgs *inp;
|
||||
union outputArgs *outp;
|
||||
int insize, outsize, error;
|
||||
#ifdef CONFIG_CODA_FS_OLD_API
|
||||
struct coda_cred cred = { 0, };
|
||||
cred.cr_fsuid = uid;
|
||||
#endif
|
||||
|
||||
insize = SIZE(release);
|
||||
UPARG(CODA_CLOSE);
|
||||
|
||||
#ifdef CONFIG_CODA_FS_OLD_API
|
||||
memcpy(&(inp->ih.cred), &cred, sizeof(cred));
|
||||
#else
|
||||
inp->ih.uid = uid;
|
||||
#endif
|
||||
|
||||
inp->coda_close.VFid = *fid;
|
||||
inp->coda_close.flags = flags;
|
||||
|
||||
|
Reference in New Issue
Block a user