[SCSI] bfa: Revised Fabric Assigned Address(FAA) feature implementation.
Made changes to the Fabric Assigned Address(FAA) feature implementation. Introduced the IOCFC state machine, which now handles the FAA logic, IOC and BFA sub-modules enablement. Removed un-wanted FAA enable/disable routines; FAA is enabled by default. Signed-off-by: Krishna Gudipati <kgudipat@brocade.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Цей коміт міститься в:

зафіксовано
James Bottomley

джерело
a6b963db0d
коміт
db9d8a75af
@@ -88,7 +88,6 @@ static void bfa_ioc_hb_monitor(struct bfa_ioc_s *ioc);
|
||||
static void bfa_ioc_mbox_poll(struct bfa_ioc_s *ioc);
|
||||
static void bfa_ioc_mbox_flush(struct bfa_ioc_s *ioc);
|
||||
static void bfa_ioc_recover(struct bfa_ioc_s *ioc);
|
||||
static void bfa_ioc_check_attr_wwns(struct bfa_ioc_s *ioc);
|
||||
static void bfa_ioc_event_notify(struct bfa_ioc_s *ioc ,
|
||||
enum bfa_ioc_event_e event);
|
||||
static void bfa_ioc_disable_comp(struct bfa_ioc_s *ioc);
|
||||
@@ -113,7 +112,6 @@ enum ioc_event {
|
||||
IOC_E_HWERROR = 10, /* hardware error interrupt */
|
||||
IOC_E_TIMEOUT = 11, /* timeout */
|
||||
IOC_E_HWFAILED = 12, /* PCI mapping failure notice */
|
||||
IOC_E_FWRSP_ACQ_ADDR = 13, /* Acquiring address */
|
||||
};
|
||||
|
||||
bfa_fsm_state_decl(bfa_ioc, uninit, struct bfa_ioc_s, enum ioc_event);
|
||||
@@ -126,7 +124,6 @@ bfa_fsm_state_decl(bfa_ioc, fail, struct bfa_ioc_s, enum ioc_event);
|
||||
bfa_fsm_state_decl(bfa_ioc, disabling, struct bfa_ioc_s, enum ioc_event);
|
||||
bfa_fsm_state_decl(bfa_ioc, disabled, struct bfa_ioc_s, enum ioc_event);
|
||||
bfa_fsm_state_decl(bfa_ioc, hwfail, struct bfa_ioc_s, enum ioc_event);
|
||||
bfa_fsm_state_decl(bfa_ioc, acq_addr, struct bfa_ioc_s, enum ioc_event);
|
||||
|
||||
static struct bfa_sm_table_s ioc_sm_table[] = {
|
||||
{BFA_SM(bfa_ioc_sm_uninit), BFA_IOC_UNINIT},
|
||||
@@ -139,7 +136,6 @@ static struct bfa_sm_table_s ioc_sm_table[] = {
|
||||
{BFA_SM(bfa_ioc_sm_disabling), BFA_IOC_DISABLING},
|
||||
{BFA_SM(bfa_ioc_sm_disabled), BFA_IOC_DISABLED},
|
||||
{BFA_SM(bfa_ioc_sm_hwfail), BFA_IOC_HWFAIL},
|
||||
{BFA_SM(bfa_ioc_sm_acq_addr), BFA_IOC_ACQ_ADDR},
|
||||
};
|
||||
|
||||
/*
|
||||
@@ -370,17 +366,9 @@ bfa_ioc_sm_getattr(struct bfa_ioc_s *ioc, enum ioc_event event)
|
||||
switch (event) {
|
||||
case IOC_E_FWRSP_GETATTR:
|
||||
bfa_ioc_timer_stop(ioc);
|
||||
bfa_ioc_check_attr_wwns(ioc);
|
||||
bfa_ioc_hb_monitor(ioc);
|
||||
bfa_fsm_set_state(ioc, bfa_ioc_sm_op);
|
||||
break;
|
||||
|
||||
case IOC_E_FWRSP_ACQ_ADDR:
|
||||
bfa_ioc_timer_stop(ioc);
|
||||
bfa_ioc_hb_monitor(ioc);
|
||||
bfa_fsm_set_state(ioc, bfa_ioc_sm_acq_addr);
|
||||
break;
|
||||
|
||||
case IOC_E_PFFAILED:
|
||||
case IOC_E_HWERROR:
|
||||
bfa_ioc_timer_stop(ioc);
|
||||
@@ -405,51 +393,6 @@ bfa_ioc_sm_getattr(struct bfa_ioc_s *ioc, enum ioc_event event)
|
||||
}
|
||||
}
|
||||
|
||||
/*
|
||||
* Acquiring address from fabric (entry function)
|
||||
*/
|
||||
static void
|
||||
bfa_ioc_sm_acq_addr_entry(struct bfa_ioc_s *ioc)
|
||||
{
|
||||
}
|
||||
|
||||
/*
|
||||
* Acquiring address from the fabric
|
||||
*/
|
||||
static void
|
||||
bfa_ioc_sm_acq_addr(struct bfa_ioc_s *ioc, enum ioc_event event)
|
||||
{
|
||||
bfa_trc(ioc, event);
|
||||
|
||||
switch (event) {
|
||||
case IOC_E_FWRSP_GETATTR:
|
||||
bfa_ioc_check_attr_wwns(ioc);
|
||||
bfa_fsm_set_state(ioc, bfa_ioc_sm_op);
|
||||
break;
|
||||
|
||||
case IOC_E_PFFAILED:
|
||||
case IOC_E_HWERROR:
|
||||
bfa_hb_timer_stop(ioc);
|
||||
case IOC_E_HBFAIL:
|
||||
ioc->cbfn->enable_cbfn(ioc->bfa, BFA_STATUS_IOC_FAILURE);
|
||||
bfa_fsm_set_state(ioc, bfa_ioc_sm_fail);
|
||||
if (event != IOC_E_PFFAILED)
|
||||
bfa_fsm_send_event(&ioc->iocpf, IOCPF_E_GETATTRFAIL);
|
||||
break;
|
||||
|
||||
case IOC_E_DISABLE:
|
||||
bfa_hb_timer_stop(ioc);
|
||||
bfa_fsm_set_state(ioc, bfa_ioc_sm_disabling);
|
||||
break;
|
||||
|
||||
case IOC_E_ENABLE:
|
||||
break;
|
||||
|
||||
default:
|
||||
bfa_sm_fault(ioc, event);
|
||||
}
|
||||
}
|
||||
|
||||
static void
|
||||
bfa_ioc_sm_op_entry(struct bfa_ioc_s *ioc)
|
||||
{
|
||||
@@ -457,6 +400,7 @@ bfa_ioc_sm_op_entry(struct bfa_ioc_s *ioc)
|
||||
|
||||
ioc->cbfn->enable_cbfn(ioc->bfa, BFA_STATUS_OK);
|
||||
bfa_ioc_event_notify(ioc, BFA_IOC_E_ENABLED);
|
||||
bfa_ioc_hb_monitor(ioc);
|
||||
BFA_LOG(KERN_INFO, bfad, bfa_log_level, "IOC enabled\n");
|
||||
bfa_ioc_aen_post(ioc, BFA_IOC_AEN_ENABLE);
|
||||
}
|
||||
@@ -2156,10 +2100,6 @@ bfa_ioc_isr(struct bfa_ioc_s *ioc, struct bfi_mbmsg_s *m)
|
||||
bfa_ioc_getattr_reply(ioc);
|
||||
break;
|
||||
|
||||
case BFI_IOC_I2H_ACQ_ADDR_REPLY:
|
||||
bfa_fsm_send_event(ioc, IOC_E_FWRSP_ACQ_ADDR);
|
||||
break;
|
||||
|
||||
default:
|
||||
bfa_trc(ioc, msg->mh.msg_id);
|
||||
WARN_ON(1);
|
||||
@@ -2449,15 +2389,6 @@ bfa_ioc_is_disabled(struct bfa_ioc_s *ioc)
|
||||
bfa_fsm_cmp_state(ioc, bfa_ioc_sm_disabled);
|
||||
}
|
||||
|
||||
/*
|
||||
* Return TRUE if IOC is in acquiring address state
|
||||
*/
|
||||
bfa_boolean_t
|
||||
bfa_ioc_is_acq_addr(struct bfa_ioc_s *ioc)
|
||||
{
|
||||
return bfa_fsm_cmp_state(ioc, bfa_ioc_sm_acq_addr);
|
||||
}
|
||||
|
||||
/*
|
||||
* return true if IOC firmware is different.
|
||||
*/
|
||||
@@ -2950,17 +2881,6 @@ bfa_ioc_recover(struct bfa_ioc_s *ioc)
|
||||
bfa_fsm_send_event(ioc, IOC_E_HBFAIL);
|
||||
}
|
||||
|
||||
static void
|
||||
bfa_ioc_check_attr_wwns(struct bfa_ioc_s *ioc)
|
||||
{
|
||||
if (bfa_ioc_get_type(ioc) == BFA_IOC_TYPE_LL)
|
||||
return;
|
||||
if (ioc->attr->nwwn == 0)
|
||||
bfa_ioc_aen_post(ioc, BFA_IOC_AEN_INVALID_NWWN);
|
||||
if (ioc->attr->pwwn == 0)
|
||||
bfa_ioc_aen_post(ioc, BFA_IOC_AEN_INVALID_PWWN);
|
||||
}
|
||||
|
||||
/*
|
||||
* BFA IOC PF private functions
|
||||
*/
|
||||
@@ -5675,24 +5595,27 @@ bfa_dconf_sm_uninit(struct bfa_dconf_mod_s *dconf, enum bfa_dconf_event event)
|
||||
case BFA_DCONF_SM_INIT:
|
||||
if (dconf->min_cfg) {
|
||||
bfa_trc(dconf->bfa, dconf->min_cfg);
|
||||
bfa_fsm_send_event(&dconf->bfa->iocfc,
|
||||
IOCFC_E_DCONF_DONE);
|
||||
return;
|
||||
}
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_flash_read);
|
||||
dconf->flashdone = BFA_FALSE;
|
||||
bfa_trc(dconf->bfa, dconf->flashdone);
|
||||
bfa_timer_start(dconf->bfa, &dconf->timer,
|
||||
bfa_dconf_timer, dconf, BFA_DCONF_UPDATE_TOV);
|
||||
bfa_status = bfa_flash_read_part(BFA_FLASH(dconf->bfa),
|
||||
BFA_FLASH_PART_DRV, dconf->instance,
|
||||
dconf->dconf,
|
||||
sizeof(struct bfa_dconf_s), 0,
|
||||
bfa_dconf_init_cb, dconf->bfa);
|
||||
if (bfa_status != BFA_STATUS_OK) {
|
||||
bfa_timer_stop(&dconf->timer);
|
||||
bfa_dconf_init_cb(dconf->bfa, BFA_STATUS_FAILED);
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_uninit);
|
||||
return;
|
||||
}
|
||||
break;
|
||||
case BFA_DCONF_SM_EXIT:
|
||||
dconf->flashdone = BFA_TRUE;
|
||||
bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_DCONF_DONE);
|
||||
case BFA_DCONF_SM_IOCDISABLE:
|
||||
case BFA_DCONF_SM_WR:
|
||||
case BFA_DCONF_SM_FLASH_COMP:
|
||||
@@ -5713,15 +5636,20 @@ bfa_dconf_sm_flash_read(struct bfa_dconf_mod_s *dconf,
|
||||
|
||||
switch (event) {
|
||||
case BFA_DCONF_SM_FLASH_COMP:
|
||||
bfa_timer_stop(&dconf->timer);
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_ready);
|
||||
break;
|
||||
case BFA_DCONF_SM_TIMEOUT:
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_ready);
|
||||
bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_IOC_FAILED);
|
||||
break;
|
||||
case BFA_DCONF_SM_EXIT:
|
||||
dconf->flashdone = BFA_TRUE;
|
||||
bfa_trc(dconf->bfa, dconf->flashdone);
|
||||
bfa_timer_stop(&dconf->timer);
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_uninit);
|
||||
bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_DCONF_DONE);
|
||||
break;
|
||||
case BFA_DCONF_SM_IOCDISABLE:
|
||||
bfa_timer_stop(&dconf->timer);
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_uninit);
|
||||
break;
|
||||
default:
|
||||
@@ -5744,9 +5672,8 @@ bfa_dconf_sm_ready(struct bfa_dconf_mod_s *dconf, enum bfa_dconf_event event)
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_dirty);
|
||||
break;
|
||||
case BFA_DCONF_SM_EXIT:
|
||||
dconf->flashdone = BFA_TRUE;
|
||||
bfa_trc(dconf->bfa, dconf->flashdone);
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_uninit);
|
||||
bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_DCONF_DONE);
|
||||
break;
|
||||
case BFA_DCONF_SM_INIT:
|
||||
case BFA_DCONF_SM_IOCDISABLE:
|
||||
@@ -5808,9 +5735,7 @@ bfa_dconf_sm_final_sync(struct bfa_dconf_mod_s *dconf,
|
||||
bfa_timer_stop(&dconf->timer);
|
||||
case BFA_DCONF_SM_TIMEOUT:
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_uninit);
|
||||
dconf->flashdone = BFA_TRUE;
|
||||
bfa_trc(dconf->bfa, dconf->flashdone);
|
||||
bfa_ioc_disable(&dconf->bfa->ioc);
|
||||
bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_DCONF_DONE);
|
||||
break;
|
||||
default:
|
||||
bfa_sm_fault(dconf->bfa, event);
|
||||
@@ -5857,8 +5782,8 @@ bfa_dconf_sm_iocdown_dirty(struct bfa_dconf_mod_s *dconf,
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_dirty);
|
||||
break;
|
||||
case BFA_DCONF_SM_EXIT:
|
||||
dconf->flashdone = BFA_TRUE;
|
||||
bfa_sm_set_state(dconf, bfa_dconf_sm_uninit);
|
||||
bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_DCONF_DONE);
|
||||
break;
|
||||
case BFA_DCONF_SM_IOCDISABLE:
|
||||
break;
|
||||
@@ -5899,11 +5824,6 @@ bfa_dconf_attach(struct bfa_s *bfa, void *bfad, struct bfa_iocfc_cfg_s *cfg,
|
||||
if (cfg->drvcfg.min_cfg) {
|
||||
bfa_mem_kva_curp(dconf) += sizeof(struct bfa_dconf_hdr_s);
|
||||
dconf->min_cfg = BFA_TRUE;
|
||||
/*
|
||||
* Set the flashdone flag to TRUE explicitly as no flash
|
||||
* write will happen in min_cfg mode.
|
||||
*/
|
||||
dconf->flashdone = BFA_TRUE;
|
||||
} else {
|
||||
dconf->min_cfg = BFA_FALSE;
|
||||
bfa_mem_kva_curp(dconf) += sizeof(struct bfa_dconf_s);
|
||||
@@ -5919,9 +5839,7 @@ bfa_dconf_init_cb(void *arg, bfa_status_t status)
|
||||
struct bfa_s *bfa = arg;
|
||||
struct bfa_dconf_mod_s *dconf = BFA_DCONF_MOD(bfa);
|
||||
|
||||
dconf->flashdone = BFA_TRUE;
|
||||
bfa_trc(bfa, dconf->flashdone);
|
||||
bfa_iocfc_cb_dconf_modinit(bfa, status);
|
||||
bfa_sm_send_event(dconf, BFA_DCONF_SM_FLASH_COMP);
|
||||
if (status == BFA_STATUS_OK) {
|
||||
bfa_dconf_read_data_valid(bfa) = BFA_TRUE;
|
||||
if (dconf->dconf->hdr.signature != BFI_DCONF_SIGNATURE)
|
||||
@@ -5929,7 +5847,7 @@ bfa_dconf_init_cb(void *arg, bfa_status_t status)
|
||||
if (dconf->dconf->hdr.version != BFI_DCONF_VERSION)
|
||||
dconf->dconf->hdr.version = BFI_DCONF_VERSION;
|
||||
}
|
||||
bfa_sm_send_event(dconf, BFA_DCONF_SM_FLASH_COMP);
|
||||
bfa_fsm_send_event(&bfa->iocfc, IOCFC_E_DCONF_DONE);
|
||||
}
|
||||
|
||||
void
|
||||
@@ -6011,7 +5929,5 @@ void
|
||||
bfa_dconf_modexit(struct bfa_s *bfa)
|
||||
{
|
||||
struct bfa_dconf_mod_s *dconf = BFA_DCONF_MOD(bfa);
|
||||
BFA_DCONF_MOD(bfa)->flashdone = BFA_FALSE;
|
||||
bfa_trc(bfa, BFA_DCONF_MOD(bfa)->flashdone);
|
||||
bfa_sm_send_event(dconf, BFA_DCONF_SM_EXIT);
|
||||
}
|
||||
|
Посилання в новій задачі
Заблокувати користувача