ALSA: gus: Remove always NULL parameters
snd_gf1_pcm_new() and snd_gf1_rawmidi_new() take a pointer to a pointer of a PCM/MIDI where if this parameter is provided the newly allocated object is stored. All callers pass NULL though, so remove the parameter. This makes the code a bit cleaner and shorter. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Цей коміт міститься в:

зафіксовано
Takashi Iwai

джерело
1a2515ac94
коміт
db5abb3c49
@@ -241,13 +241,11 @@ static struct snd_rawmidi_ops snd_gf1_uart_input =
|
||||
.trigger = snd_gf1_uart_input_trigger,
|
||||
};
|
||||
|
||||
int snd_gf1_rawmidi_new(struct snd_gus_card * gus, int device, struct snd_rawmidi ** rrawmidi)
|
||||
int snd_gf1_rawmidi_new(struct snd_gus_card *gus, int device)
|
||||
{
|
||||
struct snd_rawmidi *rmidi;
|
||||
int err;
|
||||
|
||||
if (rrawmidi)
|
||||
*rrawmidi = NULL;
|
||||
if ((err = snd_rawmidi_new(gus->card, "GF1", device, 1, 1, &rmidi)) < 0)
|
||||
return err;
|
||||
strcpy(rmidi->name, gus->interwave ? "AMD InterWave" : "GF1");
|
||||
@@ -256,7 +254,5 @@ int snd_gf1_rawmidi_new(struct snd_gus_card * gus, int device, struct snd_rawmid
|
||||
rmidi->info_flags |= SNDRV_RAWMIDI_INFO_OUTPUT | SNDRV_RAWMIDI_INFO_INPUT | SNDRV_RAWMIDI_INFO_DUPLEX;
|
||||
rmidi->private_data = gus;
|
||||
gus->midi_uart = rmidi;
|
||||
if (rrawmidi)
|
||||
*rrawmidi = rmidi;
|
||||
return err;
|
||||
}
|
||||
|
Посилання в новій задачі
Заблокувати користувача