ALSA: gus: Remove always NULL parameters
snd_gf1_pcm_new() and snd_gf1_rawmidi_new() take a pointer to a pointer of a PCM/MIDI where if this parameter is provided the newly allocated object is stored. All callers pass NULL though, so remove the parameter. This makes the code a bit cleaner and shorter. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:

committed by
Takashi Iwai

parent
1a2515ac94
commit
db5abb3c49
@@ -849,7 +849,7 @@ static struct snd_pcm_ops snd_gf1_pcm_capture_ops = {
|
||||
.pointer = snd_gf1_pcm_capture_pointer,
|
||||
};
|
||||
|
||||
int snd_gf1_pcm_new(struct snd_gus_card * gus, int pcm_dev, int control_index, struct snd_pcm ** rpcm)
|
||||
int snd_gf1_pcm_new(struct snd_gus_card *gus, int pcm_dev, int control_index)
|
||||
{
|
||||
struct snd_card *card;
|
||||
struct snd_kcontrol *kctl;
|
||||
@@ -857,8 +857,6 @@ int snd_gf1_pcm_new(struct snd_gus_card * gus, int pcm_dev, int control_index, s
|
||||
struct snd_pcm_substream *substream;
|
||||
int capture, err;
|
||||
|
||||
if (rpcm)
|
||||
*rpcm = NULL;
|
||||
card = gus->card;
|
||||
capture = !gus->interwave && !gus->ess_flag && !gus->ace_flag ? 1 : 0;
|
||||
err = snd_pcm_new(card,
|
||||
@@ -903,8 +901,6 @@ int snd_gf1_pcm_new(struct snd_gus_card * gus, int pcm_dev, int control_index, s
|
||||
return err;
|
||||
kctl->id.index = control_index;
|
||||
|
||||
if (rpcm)
|
||||
*rpcm = pcm;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user