xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

block_device_operations->release() should return void

Browse Source 
The value passed is 0 in all but "it can never happen" cases (and those
only in a couple of drivers) *and* it would've been lost on the way
out anyway, even if something tried to pass something meaningful.
Just don't bother.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2013-05-05 21:52:57 -04:00
parent a8ca889ed9
commit db2a144bed
37 changed files with 62 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/block/loop.c
View File

@@ -1518,7 +1518,7 @@ out:
return err;
}
static int lo_release(struct gendisk *disk, fmode_t mode)
static void lo_release(struct gendisk *disk, fmode_t mode)
{
struct loop_device *lo = disk->private_data;
int err;
@@ -1535,7 +1535,7 @@ static int lo_release(struct gendisk *disk, fmode_t mode)
*/
err = loop_clr_fd(lo);
if (!err)
goto out_unlocked;
return;
} else {
/*
* Otherwise keep thread (if running) and config,
@@ -1546,8 +1546,6 @@ static int lo_release(struct gendisk *disk, fmode_t mode)
out:
mutex_unlock(&lo->lo_ctl_mutex);
out_unlocked:
return 0;
}
static const struct block_device_operations lo_fops = {